diff --git a/apps/desktop/src/autofill/services/desktop-fido2-user-interface.service.ts b/apps/desktop/src/autofill/services/desktop-fido2-user-interface.service.ts index e08a288e044..0cba3459cd3 100644 --- a/apps/desktop/src/autofill/services/desktop-fido2-user-interface.service.ts +++ b/apps/desktop/src/autofill/services/desktop-fido2-user-interface.service.ts @@ -33,8 +33,13 @@ import { SecureNoteView } from "@bitwarden/common/vault/models/view/secure-note. import { DesktopSettingsService } from "src/platform/services/desktop-settings.service"; -// This type is used to pass the window position from the native UI +/** + * This type is used to pass the window position from the native UI + */ export type NativeWindowObject = { + /** + * The position of the window, first entry is the x position, second is the y position + */ windowXy?: [number, number]; }; @@ -58,10 +63,10 @@ export class DesktopFido2UserInterfaceService async newSession( fallbackSupported: boolean, - _tab: NativeWindowObject, + nativeWindowObject: NativeWindowObject, abortController?: AbortController, ): Promise { - this.logService.warning("newSession", fallbackSupported, abortController, _tab); + this.logService.warning("newSession", fallbackSupported, abortController, nativeWindowObject); const session = new DesktopFido2UserInterfaceSession( this.authService, this.cipherService, @@ -69,7 +74,7 @@ export class DesktopFido2UserInterfaceService this.logService, this.router, this.desktopSettingsService, - _tab, + nativeWindowObject, ); this.currentSession = session; diff --git a/apps/desktop/src/main/window.main.ts b/apps/desktop/src/main/window.main.ts index 1a1151e62a3..5a600070d56 100644 --- a/apps/desktop/src/main/window.main.ts +++ b/apps/desktop/src/main/window.main.ts @@ -203,6 +203,8 @@ export class WindowMain { } } + // TODO: REMOVE ONCE WE CAN STOP USING FAKE POP UP BTN FROM TRAY + // Only used during initial UI development async loadUrl(targetPath: string, modal: boolean = false) { if (this.win == null || this.win.isDestroyed()) { await this.createWindow("modal-app");