bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-15 15:53:27 +00:00
Code Issues Releases Wiki Activity

[PM-1684] Broken roboform importer (#5137)

Browse Source 
* PM-1684 - Set null or empty validation on start of processFolder method

* PM-1684 - Added tests to roboform-csv-importer
This commit is contained in:
aj-rosado
2023-04-07 11:23:34 +01:00
committed by GitHub
parent 3c2aa02201
commit 2ad739b5a8
4 changed files with 61 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
libs/importer/src/importers/base-importer.ts
View File

@@ -411,19 +411,20 @@ export abstract class BaseImporter {
}
protected processFolder(result: ImportResult, folderName: string) {
if (this.isNullOrWhitespace(folderName)) {
return;
}
let folderIndex = result.folders.length;
const hasFolder = !this.isNullOrWhitespace(folderName);
// Replace backslashes with forward slashes, ensuring we create sub-folders
folderName = folderName.replace("\\", "/");
let addFolder = hasFolder;
let addFolder = true;
if (hasFolder) {
for (let i = 0; i < result.folders.length; i++) {
if (result.folders[i].name === folderName) {
addFolder = false;
folderIndex = i;
break;
}
for (let i = 0; i < result.folders.length; i++) {
if (result.folders[i].name === folderName) {
addFolder = false;
folderIndex = i;
break;
}
}
@@ -432,9 +433,8 @@ export abstract class BaseImporter {
f.name = folderName;
result.folders.push(f);
}
if (hasFolder) {
result.folderRelationships.push([result.ciphers.length, folderIndex]);
}
result.folderRelationships.push([result.ciphers.length, folderIndex]);
}
protected convertToNoteIfNeeded(cipher: CipherView) {