bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-16 16:23:44 +00:00
Code Issues Releases Wiki Activity

Convert refactoring todo-rr-bw to standard todos.

Browse Source
This commit is contained in:
Alec Rippberger
2024-10-01 14:40:32 -05:00
parent f42a391b6f
commit 2d5f4dfb70
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libs/auth/src/angular/login/default-login-component.service.ts
View File

@@ -16,7 +16,7 @@ export class DefaultLoginComponentService implements LoginComponentService {
constructor( constructor(
protected cryptoFunctionService: CryptoFunctionService, protected cryptoFunctionService: CryptoFunctionService,
protected environmentService: EnvironmentService, protected environmentService: EnvironmentService,
// TODO-rr-bw: refactor to not use deprecated service // TODO: refactor to not use deprecated service
protected passwordGenerationService: PasswordGenerationServiceAbstraction, protected passwordGenerationService: PasswordGenerationServiceAbstraction,
protected platformUtilsService: PlatformUtilsService, protected platformUtilsService: PlatformUtilsService,
protected ssoLoginService: SsoLoginServiceAbstraction, protected ssoLoginService: SsoLoginServiceAbstraction,

4
libs/auth/src/angular/login/login.component.ts
View File

@@ -161,7 +161,7 @@ export class LoginComponent implements OnInit, OnDestroy {
ngOnDestroy(): void { ngOnDestroy(): void {
if (this.clientType === ClientType.Desktop) { if (this.clientType === ClientType.Desktop) {
// TODO-rr-bw: refactor to not use deprecated broadcaster service. // TODO: refactor to not use deprecated broadcaster service.
this.broadcasterService.unsubscribe(BroadcasterSubscriptionId); this.broadcasterService.unsubscribe(BroadcasterSubscriptionId);
} }
@@ -534,7 +534,7 @@ export class LoginComponent implements OnInit, OnDestroy {
private async desktopOnInit(): Promise<void> { private async desktopOnInit(): Promise<void> {
await this.getLoginWithDevice(this.loggedEmail); await this.getLoginWithDevice(this.loggedEmail);
// TODO-rr-bw: refactor to not use deprecated broadcaster service. // TODO: refactor to not use deprecated broadcaster service.
this.broadcasterService.subscribe(BroadcasterSubscriptionId, async (message: any) => { this.broadcasterService.subscribe(BroadcasterSubscriptionId, async (message: any) => {
this.ngZone.run(() => { this.ngZone.run(() => {
switch (message.command) { switch (message.command) {