bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-11 22:03:36 +00:00
Code Issues Releases Wiki Activity

[PM-24796] Ensure the CipherView prototype is not lost within the cache Signal (#16267)

Browse Source
This commit is contained in:
Shane Melton
2025-09-03 09:34:35 -07:00
committed by GitHub
parent 73e8532ecc
commit 2de321d6e8
2 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libs/vault/src/cipher-form/services/default-cipher-form-cache.service.spec.ts
View File

@@ -2,6 +2,7 @@ import { signal } from "@angular/core";
import { TestBed } from "@angular/core/testing"; import { TestBed } from "@angular/core/testing";
import { ViewCacheService } from "@bitwarden/angular/platform/view-cache"; import { ViewCacheService } from "@bitwarden/angular/platform/view-cache";
import { Cipher } from "@bitwarden/common/vault/models/domain/cipher";
import { CipherView } from "@bitwarden/common/vault/models/view/cipher.view"; import { CipherView } from "@bitwarden/common/vault/models/view/cipher.view";
import { CipherFormCacheService } from "./default-cipher-form-cache.service"; import { CipherFormCacheService } from "./default-cipher-form-cache.service";
@@ -36,9 +37,10 @@ describe("CipherFormCacheService", () => {
it("updates the signal value", async () => { it("updates the signal value", async () => {
service = testBed.inject(CipherFormCacheService); service = testBed.inject(CipherFormCacheService);
service.cacheCipherView({ id: "cipher-5" } as CipherView); service.cacheCipherView(new CipherView({ id: "cipher-5" } as Cipher));
expect(cacheSignal.set).toHaveBeenCalledWith({ id: "cipher-5" }); expect(cacheSignal.set).toHaveBeenCalledWith(expect.any(CipherView)); // Ensure we keep the CipherView prototype
expect(cacheSignal.set).toHaveBeenCalledWith(expect.objectContaining({ id: "cipher-5" }));
}); });
describe("initializedWithValue", () => { describe("initializedWithValue", () => {

5
libs/vault/src/cipher-form/services/default-cipher-form-cache.service.ts
View File

@@ -1,4 +1,5 @@
import { inject, Injectable } from "@angular/core"; import { inject, Injectable } from "@angular/core";
import { Jsonify } from "type-fest";
import { ViewCacheService } from "@bitwarden/angular/platform/view-cache"; import { ViewCacheService } from "@bitwarden/angular/platform/view-cache";
import { CipherView } from "@bitwarden/common/vault/models/view/cipher.view"; import { CipherView } from "@bitwarden/common/vault/models/view/cipher.view";
@@ -32,10 +33,10 @@ export class CipherFormCacheService {
* Update the cache with the new CipherView. * Update the cache with the new CipherView.
*/ */
cacheCipherView(cipherView: CipherView): void { cacheCipherView(cipherView: CipherView): void {
// Create a new shallow reference to force the signal to update // Create a new reference to force the signal to update
// By default, signals use `Object.is` to determine equality // By default, signals use `Object.is` to determine equality
// Docs: https://angular.dev/guide/signals#signal-equality-functions // Docs: https://angular.dev/guide/signals#signal-equality-functions
this.cipherCache.set({ ...cipherView } as CipherView); this.cipherCache.set(CipherView.fromJSON(cipherView as Jsonify<CipherView>));
} }
/** /**