From 2e5f9e58d323817e16b862a3fbfd6252b13ff3b5 Mon Sep 17 00:00:00 2001
From: Andreas Coroiu <andreas.coroiu@gmail.com>
Date: Wed, 10 May 2023 12:00:52 +0200
Subject: [PATCH] [PM-2014] feat: improve aria labels

---
 .../fido2-login-settings.component.html               | 11 +++++++++--
 apps/web/src/locales/en/messages.json                 |  3 ---
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/apps/web/src/app/auth/settings/fido2-login-settings/fido2-login-settings.component.html b/apps/web/src/app/auth/settings/fido2-login-settings/fido2-login-settings.component.html
index 3036e4b07b1..0814ef80746 100644
--- a/apps/web/src/app/auth/settings/fido2-login-settings/fido2-login-settings.component.html
+++ b/apps/web/src/app/auth/settings/fido2-login-settings/fido2-login-settings.component.html
@@ -24,7 +24,14 @@
       <ng-container *ngIf="!credential.prfSupport">-</ng-container>
     </td>
     <td class="tw-py-2 tw-pl-20 tw-pr-0">
-      <button type="button" bitLink [disabled]="loading">{{ "remove" | i18n }}</button>
+      <button
+        type="button"
+        bitLink
+        [disabled]="loading"
+        [attr.aria-label]="('remove' | i18n) + ' ' + credential.name"
+      >
+        {{ "remove" | i18n }}
+      </button>
     </td>
   </tr>
 </table>
@@ -44,7 +51,7 @@
     *ngIf="!hasCredentials"
     type="button"
     bitButton
-    [attr.aria-label]="'enableLoginWithPasskey' | i18n"
+    [attr.aria-label]="('enable' | i18n) + ' ' + ('loginWithPasskey' | i18n)"
     [disabled]="loading"
     (click)="createCredential()"
   >
diff --git a/apps/web/src/locales/en/messages.json b/apps/web/src/locales/en/messages.json
index 5b09ca85007..e0c96fd3005 100644
--- a/apps/web/src/locales/en/messages.json
+++ b/apps/web/src/locales/en/messages.json
@@ -631,9 +631,6 @@
   "loginWithPasskeyInfo": {
     "message": "Use facial recognition, a fingerprint, or other FIDO2 security key to log in instead of your email and password."
   },
-  "enableLoginWithPasskey": {
-    "message": "Turn on log in with passkey"
-  },
   "newPasskey": {
     "message": "New passkey"
   },