diff --git a/libs/components/src/anon-layout/anon-layout.component.ts b/libs/components/src/anon-layout/anon-layout.component.ts index 45e7f3973a9..1324e37a418 100644 --- a/libs/components/src/anon-layout/anon-layout.component.ts +++ b/libs/components/src/anon-layout/anon-layout.component.ts @@ -11,7 +11,7 @@ import { PlatformUtilsService } from "@bitwarden/common/platform/abstractions/pl import { IconModule, Icon } from "../icon"; import { BitwardenLogo } from "../icon/icons"; -import { BitwardenShield } from "../icon/logos"; +import { AnonLayoutBitwardenShield } from "../icon/logos"; import { SharedModule } from "../shared"; import { TypographyModule } from "../typography"; @@ -84,7 +84,7 @@ export class AnonLayoutComponent implements OnInit, OnChanges { // If there is no icon input, then use the default icon if (this.icon == null) { - this.icon = BitwardenShield; + this.icon = AnonLayoutBitwardenShield; } } diff --git a/libs/components/src/icon/logos/bitwarden/index.ts b/libs/components/src/icon/logos/bitwarden/index.ts index e786eb90e78..ba78bdb4fe5 100644 --- a/libs/components/src/icon/logos/bitwarden/index.ts +++ b/libs/components/src/icon/logos/bitwarden/index.ts @@ -1,4 +1,4 @@ export { default as AdminConsoleLogo } from "./admin-console"; -export { default as BitwardenShield } from "./shield"; +export * from "./shield"; export { default as PasswordManagerLogo } from "./password-manager"; export { default as SecretsManagerLogo } from "./secrets-manager"; diff --git a/libs/components/src/icon/logos/bitwarden/shield.ts b/libs/components/src/icon/logos/bitwarden/shield.ts index 15fe6dddf48..b942715bb6d 100644 --- a/libs/components/src/icon/logos/bitwarden/shield.ts +++ b/libs/components/src/icon/logos/bitwarden/shield.ts @@ -1,7 +1,16 @@ import { svgIcon } from "../../icon"; +/** + * Shield logo with extra space in the viewbox. + */ +const AnonLayoutBitwardenShield = svgIcon` + + + +`; + const BitwardenShield = svgIcon` `; -export default BitwardenShield; +export { AnonLayoutBitwardenShield, BitwardenShield }; diff --git a/libs/components/src/navigation/nav-item.component.html b/libs/components/src/navigation/nav-item.component.html index 15fcc74e1f9..3d4dadacffa 100644 --- a/libs/components/src/navigation/nav-item.component.html +++ b/libs/components/src/navigation/nav-item.component.html @@ -17,16 +17,16 @@ @if (open) { - {{ text }} + {{ text }} } @@ -36,7 +36,7 @@ diff --git a/libs/components/src/navigation/nav-item.stories.ts b/libs/components/src/navigation/nav-item.stories.ts index 09642fd2b1c..c51cffabb1d 100644 --- a/libs/components/src/navigation/nav-item.stories.ts +++ b/libs/components/src/navigation/nav-item.stories.ts @@ -68,6 +68,13 @@ export const WithoutIcon: Story = { }, }; +export const WithLongText: Story = { + ...Default, + args: { + text: "Hello World This Is a Cool Item", + }, +}; + export const WithoutRoute: Story = { render: () => ({ template: ` @@ -80,7 +87,7 @@ export const WithChildButtons: Story = { render: (args) => ({ props: args, template: ` - + ({ props: args, template: ` - - + + diff --git a/libs/components/src/stories/kitchen-sink/kitchen-sink.stories.ts b/libs/components/src/stories/kitchen-sink/kitchen-sink.stories.ts index 97a782b7302..9e7e6f5d3ba 100644 --- a/libs/components/src/stories/kitchen-sink/kitchen-sink.stories.ts +++ b/libs/components/src/stories/kitchen-sink/kitchen-sink.stories.ts @@ -14,6 +14,7 @@ import { import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service"; +import { PasswordManagerLogo } from "../../icon"; import { LayoutComponent } from "../../layout"; import { I18nMockService } from "../../utils/i18n-mock.service"; import { positionFixedWrapperDecorator } from "../storybook-decorators"; @@ -77,9 +78,13 @@ type Story = StoryObj; export const Default: Story = { render: (args) => { return { - props: args, + props: { + ...args, + logo: PasswordManagerLogo, + }, template: /* HTML */ ` + @@ -99,10 +104,15 @@ export const Default: Story = { `, }; }, + parameters: { + chromatic: { + viewports: [640, 1280], + }, + }, }; export const MenuOpen: Story = { - ...Default, + render: Default.render, play: async (context) => { const canvas = context.canvasElement; const table = getByRole(canvas, "table"); @@ -116,7 +126,7 @@ export const MenuOpen: Story = { }; export const DialogOpen: Story = { - ...Default, + render: Default.render, play: async (context) => { const canvas = context.canvasElement; const dialogButton = getByRole(canvas, "button", { @@ -129,7 +139,7 @@ export const DialogOpen: Story = { }; export const DrawerOpen: Story = { - ...Default, + render: Default.render, play: async (context) => { const canvas = context.canvasElement; const drawerButton = getByRole(canvas, "button", { @@ -142,7 +152,7 @@ export const DrawerOpen: Story = { }; export const PopoverOpen: Story = { - ...Default, + render: Default.render, play: async (context) => { const canvas = context.canvasElement; const passwordLabelIcon = getByLabelText(canvas, "A random password (required)", { @@ -154,7 +164,7 @@ export const PopoverOpen: Story = { }; export const SimpleDialogOpen: Story = { - ...Default, + render: Default.render, play: async (context) => { const canvas = context.canvasElement; const submitButton = getByRole(canvas, "button", { @@ -167,7 +177,7 @@ export const SimpleDialogOpen: Story = { }; export const EmptyTab: Story = { - ...Default, + render: Default.render, play: async (context) => { const canvas = context.canvasElement; const emptyTab = getByRole(canvas, "tab", { name: "Empty tab" }); @@ -176,7 +186,7 @@ export const EmptyTab: Story = { }; export const VirtualScrollBlockingDialog: Story = { - ...Default, + render: Default.render, play: async (context) => { const canvas = context.canvasElement; const navItem = getByText(canvas, "Virtual Scroll");