From 2fb9277b658c604ea2dfa83c762a0a4665ac06c3 Mon Sep 17 00:00:00 2001 From: Bernd Schoolmann Date: Mon, 3 Nov 2025 19:13:30 +0100 Subject: [PATCH] Add comments (#17177) --- .../request/master-password-unlock-data.request.ts | 7 +++++-- .../models/response/master-password-unlock.response.ts | 8 +++++--- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/apps/web/src/app/key-management/key-rotation/request/master-password-unlock-data.request.ts b/apps/web/src/app/key-management/key-rotation/request/master-password-unlock-data.request.ts index 95e54e1646..965d866c91 100644 --- a/apps/web/src/app/key-management/key-rotation/request/master-password-unlock-data.request.ts +++ b/apps/web/src/app/key-management/key-rotation/request/master-password-unlock-data.request.ts @@ -9,6 +9,9 @@ export class MasterPasswordUnlockDataRequest { email: string; masterKeyAuthenticationHash: string; + /** + * Also known as masterKeyWrappedUserKey in other parts of the codebase + */ masterKeyEncryptedUserKey: string; masterPasswordHint?: string; @@ -17,7 +20,7 @@ export class MasterPasswordUnlockDataRequest { kdfConfig: KdfConfig, email: string, masterKeyAuthenticationHash: string, - masterKeyEncryptedUserKey: string, + masterKeyWrappedUserKey: string, masterPasswordHash?: string, ) { this.kdfType = kdfConfig.kdfType; @@ -29,7 +32,7 @@ export class MasterPasswordUnlockDataRequest { this.email = email; this.masterKeyAuthenticationHash = masterKeyAuthenticationHash; - this.masterKeyEncryptedUserKey = masterKeyEncryptedUserKey; + this.masterKeyEncryptedUserKey = masterKeyWrappedUserKey; this.masterPasswordHint = masterPasswordHash; } } diff --git a/libs/common/src/key-management/master-password/models/response/master-password-unlock.response.ts b/libs/common/src/key-management/master-password/models/response/master-password-unlock.response.ts index 41b16d43f5..9f2c39dd1a 100644 --- a/libs/common/src/key-management/master-password/models/response/master-password-unlock.response.ts +++ b/libs/common/src/key-management/master-password/models/response/master-password-unlock.response.ts @@ -22,13 +22,15 @@ export class MasterPasswordUnlockResponse extends BaseResponse { this.kdf = new KdfConfigResponse(this.getResponseProperty("Kdf")); - const masterKeyEncryptedUserKey = this.getResponseProperty("MasterKeyEncryptedUserKey"); - if (masterKeyEncryptedUserKey == null || typeof masterKeyEncryptedUserKey !== "string") { + // Note: MasterKeyEncryptedUserKey and masterKeyWrappedUserKey are the same thing, and + // used inconsistently in the codebase + const masterKeyWrappedUserKey = this.getResponseProperty("MasterKeyEncryptedUserKey"); + if (masterKeyWrappedUserKey == null || typeof masterKeyWrappedUserKey !== "string") { throw new Error( "MasterPasswordUnlockResponse does not contain a valid master key encrypted user key", ); } - this.masterKeyWrappedUserKey = masterKeyEncryptedUserKey as MasterKeyWrappedUserKey; + this.masterKeyWrappedUserKey = masterKeyWrappedUserKey as MasterKeyWrappedUserKey; } toMasterPasswordUnlockData() {