From 32a40a91f50fcb0d26e72c838c6bedbb2aff6dc4 Mon Sep 17 00:00:00 2001 From: Alex <55413326+AlexRubik@users.noreply.github.com> Date: Mon, 27 Oct 2025 14:38:49 -0400 Subject: [PATCH] [PM-26929] filter at risk passwords count to only critical apps (#16879) * filter at risk passwords count to only critical apps * PM-26929 assign tasks to those apps that are marked as critical --------- Co-authored-by: voommen-livefront --- .../services/view/all-activities.service.ts | 9 +++------ .../activity-cards/password-change-metric.component.ts | 2 +- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/view/all-activities.service.ts b/bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/view/all-activities.service.ts index 97db491823..c275ad8c35 100644 --- a/bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/view/all-activities.service.ts +++ b/bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/view/all-activities.service.ts @@ -76,12 +76,9 @@ export class AllActivitiesService { } setAllAppsReportDetails(applications: ApplicationHealthReportDetailEnriched[]) { - // Only count at-risk passwords for CRITICAL applications - const criticalApps = applications.filter((app) => app.isMarkedAsCritical); - const totalAtRiskPasswords = criticalApps.reduce( - (sum, app) => sum + app.atRiskPasswordCount, - 0, - ); + const totalAtRiskPasswords = applications + .filter((app) => app.isMarkedAsCritical) + .reduce((sum, app) => sum + app.atRiskPasswordCount, 0); this.atRiskPasswordsCountSubject$.next(totalAtRiskPasswords); this.allApplicationsDetailsSubject$.next(applications); diff --git a/bitwarden_license/bit-web/src/app/dirt/access-intelligence/activity/activity-cards/password-change-metric.component.ts b/bitwarden_license/bit-web/src/app/dirt/access-intelligence/activity/activity-cards/password-change-metric.component.ts index 941d693940..5c03534720 100644 --- a/bitwarden_license/bit-web/src/app/dirt/access-intelligence/activity/activity-cards/password-change-metric.component.ts +++ b/bitwarden_license/bit-web/src/app/dirt/access-intelligence/activity/activity-cards/password-change-metric.component.ts @@ -191,7 +191,7 @@ export class PasswordChangeMetricComponent implements OnInit { async assignTasks() { await this.accessIntelligenceSecurityTasksService.assignTasks( this.organizationId, - this.allApplicationsDetails, + this.allApplicationsDetails.filter((app) => app.isMarkedAsCritical), ); } }