From 355a52f43f85998de795ba68f0392146b2abadfb Mon Sep 17 00:00:00 2001 From: Andreas Coroiu Date: Wed, 10 May 2023 13:21:09 +0200 Subject: [PATCH] [PM-2014] feat: show toast on passkey saved --- .../auth/core/services/webauthn/webauthn.service.spec.ts | 1 + .../app/auth/core/services/webauthn/webauthn.service.ts | 5 +++++ apps/web/src/locales/en/messages.json | 9 +++++++++ 3 files changed, 15 insertions(+) diff --git a/apps/web/src/app/auth/core/services/webauthn/webauthn.service.spec.ts b/apps/web/src/app/auth/core/services/webauthn/webauthn.service.spec.ts index 086965712e7..929ac1a0a83 100644 --- a/apps/web/src/app/auth/core/services/webauthn/webauthn.service.spec.ts +++ b/apps/web/src/app/auth/core/services/webauthn/webauthn.service.spec.ts @@ -100,6 +100,7 @@ describe("WebauthnService", () => { expect(result).toBe(true); expect(apiService.saveCredential).toHaveBeenCalled(); + expect(platformUtilsService.showToast).toHaveBeenCalled(); }); }); }); diff --git a/apps/web/src/app/auth/core/services/webauthn/webauthn.service.ts b/apps/web/src/app/auth/core/services/webauthn/webauthn.service.ts index 5153ae1ab8f..f6b733609ef 100644 --- a/apps/web/src/app/auth/core/services/webauthn/webauthn.service.ts +++ b/apps/web/src/app/auth/core/services/webauthn/webauthn.service.ts @@ -91,6 +91,11 @@ export class WebauthnService { request.token = credentialOptions.token; request.name = name; await this.apiService.saveCredential(request); + this.platformUtilsService.showToast( + "success", + null, + this.i18nService.t("passkeySaved", name) + ); this.refresh(); return true; } catch (error) { diff --git a/apps/web/src/locales/en/messages.json b/apps/web/src/locales/en/messages.json index e0c96fd3005..f831607c462 100644 --- a/apps/web/src/locales/en/messages.json +++ b/apps/web/src/locales/en/messages.json @@ -664,6 +664,15 @@ "supportsEncryption": { "message": "supports encryption" }, + "passkeySaved": { + "message": "$NAME$ saved", + "placeholders": { + "name": { + "content": "$1", + "example": "Personal yubikey" + } + } + }, "tryAgain": { "message": "Try again" },