[PM-24550] Remove Feature Flag Code for PM-12276 (#16173)

* tests: remove feature flag use in tests

* tests: remove breadcrumbingPolicyTests and add service tests

* refactor: remove event log use of flag from org-layout component

* refactor: remove new policy code from org-layout component

* refactor: remove event log use of flag from events component

* refactor: remove event log use from collection dialog component

* refactor: remove event log use from vault-header component

* refactor: remove event-log route logic for org-reporting

* refactor: remove logic from org-settings routing

* refactor: remove breadcrumbing function and from billing service

* refactor: remove ConfigService from DI for billing service

* refactor: remove new policy code from policy-edit component

* refactor: remove new policy code from policies component

* refactor: remove feature flag

* fix(Admin Console): revert to use of reactive observables pattern

* fix(Admin Console): remove type artifact from reversion

libs/angular/src/services/jslib-services.module.ts

@@ -1332,7 +1332,6 @@ const safeProviders: SafeProvider[] = [
       I18nServiceAbstraction,
       OrganizationApiServiceAbstraction,
       SyncService,
-      ConfigService,
     ],
   }),
   safeProvider({

libs/common/src/billing/abstractions/organization-billing.service.ts

@@ -1,7 +1,3 @@
-import { Observable } from "rxjs";
-
-import { Organization } from "@bitwarden/common/admin-console/models/domain/organization";
-
 import { OrganizationResponse } from "../../admin-console/models/response/organization.response";
 import { InitiationPath } from "../../models/request/reference-event.request";
 import { PaymentMethodType, PlanType } from "../enums";
@@ -63,10 +59,4 @@ export abstract class OrganizationBillingServiceAbstraction {
     organizationId: string,
     subscription: SubscriptionInformation,
   ): Promise<void>;
-
-  /**
-   * Determines if breadcrumbing policies is enabled for the organizations meeting certain criteria.
-   * @param organization
-   */
-  abstract isBreadcrumbingPoliciesEnabled$(organization: Organization): Observable<boolean>;
 }

libs/common/src/billing/services/organization-billing.service.spec.ts

@@ -1,22 +1,26 @@
 import { mock } from "jest-mock-extended";
-import { firstValueFrom, of } from "rxjs";
 
 import { ApiService } from "@bitwarden/common/abstractions/api.service";
 import { OrganizationApiServiceAbstraction as OrganizationApiService } from "@bitwarden/common/admin-console/abstractions/organization/organization-api.service.abstraction";
-import { Organization } from "@bitwarden/common/admin-console/models/domain/organization";
-import { BillingApiServiceAbstraction } from "@bitwarden/common/billing/abstractions";
-import { ProductTierType } from "@bitwarden/common/billing/enums";
+import {
+  BillingApiServiceAbstraction,
+  SubscriptionInformation,
+} from "@bitwarden/common/billing/abstractions";
+import { PaymentMethodType, PlanType } from "@bitwarden/common/billing/enums";
 import { OrganizationBillingService } from "@bitwarden/common/billing/services/organization-billing.service";
-import { FeatureFlag } from "@bitwarden/common/enums/feature-flag.enum";
 import { EncryptService } from "@bitwarden/common/key-management/crypto/abstractions/encrypt.service";
-import { ConfigService } from "@bitwarden/common/platform/abstractions/config/config.service";
 import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service";
 import { SyncService } from "@bitwarden/common/platform/sync";
 // This import has been flagged as unallowed for this class. It may be involved in a circular dependency loop.
 // eslint-disable-next-line no-restricted-imports
 import { KeyService } from "@bitwarden/key-management";
 
-describe("BillingAccountProfileStateService", () => {
+import { OrganizationResponse } from "../../admin-console/models/response/organization.response";
+import { EncString } from "../../key-management/crypto/models/enc-string";
+import { OrgKey } from "../../types/key";
+import { PaymentMethodResponse } from "../models/response/payment-method.response";
+
+describe("OrganizationBillingService", () => {
   let apiService: jest.Mocked<ApiService>;
   let billingApiService: jest.Mocked<BillingApiServiceAbstraction>;
   let keyService: jest.Mocked<KeyService>;
@@ -24,7 +28,6 @@ describe("BillingAccountProfileStateService", () => {
   let i18nService: jest.Mocked<I18nService>;
   let organizationApiService: jest.Mocked<OrganizationApiService>;
   let syncService: jest.Mocked<SyncService>;
-  let configService: jest.Mocked<ConfigService>;
 
   let sut: OrganizationBillingService;
 
@@ -36,7 +39,6 @@ describe("BillingAccountProfileStateService", () => {
     i18nService = mock<I18nService>();
     organizationApiService = mock<OrganizationApiService>();
     syncService = mock<SyncService>();
-    configService = mock<ConfigService>();
 
     sut = new OrganizationBillingService(
       apiService,
@@ -46,7 +48,6 @@ describe("BillingAccountProfileStateService", () => {
       i18nService,
       organizationApiService,
       syncService,
-      configService,
     );
   });
 
@@ -54,98 +55,246 @@ describe("BillingAccountProfileStateService", () => {
     return jest.resetAllMocks();
   });
 
-  describe("isBreadcrumbingPoliciesEnabled", () => {
-    it("returns false when feature flag is disabled", async () => {
-      configService.getFeatureFlag$.mockReturnValue(of(false));
-      const org = {
-        isProviderUser: false,
-        canEditSubscription: true,
-        productTierType: ProductTierType.Teams,
-      } as Organization;
+  describe("getPaymentSource()", () => {
+    it("given a valid organization id, then it returns a payment source", async () => {
+      //Arrange
+      const orgId = "organization-test";
+      const paymentMethodResponse = {
+        paymentSource: { type: PaymentMethodType.Card },
+      } as PaymentMethodResponse;
+      billingApiService.getOrganizationPaymentMethod.mockResolvedValue(paymentMethodResponse);
 
-      const actual = await firstValueFrom(sut.isBreadcrumbingPoliciesEnabled$(org));
-      expect(actual).toBe(false);
-      expect(configService.getFeatureFlag$).toHaveBeenCalledWith(
-        FeatureFlag.PM12276_BreadcrumbEventLogs,
+      //Act
+      const returnedPaymentSource = await sut.getPaymentSource(orgId);
+
+      //Assert
+      expect(billingApiService.getOrganizationPaymentMethod).toHaveBeenCalledTimes(1);
+      expect(returnedPaymentSource).toEqual(paymentMethodResponse.paymentSource);
+    });
+
+    it("given an invalid organizationId, it should return undefined", async () => {
+      //Arrange
+      const orgId = "invalid-id";
+      billingApiService.getOrganizationPaymentMethod.mockResolvedValue(null);
+
+      //Act
+      const returnedPaymentSource = await sut.getPaymentSource(orgId);
+
+      //Assert
+      expect(billingApiService.getOrganizationPaymentMethod).toHaveBeenCalledTimes(1);
+      expect(returnedPaymentSource).toBeUndefined();
+    });
+
+    it("given an API error occurs, then it throws the error", async () => {
+      // Arrange
+      const orgId = "error-org";
+      billingApiService.getOrganizationPaymentMethod.mockRejectedValue(new Error("API Error"));
+
+      // Act & Assert
+      await expect(sut.getPaymentSource(orgId)).rejects.toThrow("API Error");
+      expect(billingApiService.getOrganizationPaymentMethod).toHaveBeenCalledTimes(1);
+    });
+  });
+
+  describe("purchaseSubscription()", () => {
+    it("given valid subscription information, then it returns successful response", async () => {
+      //Arrange
+      const subscriptionInformation = {
+        organization: { name: "test-business", billingEmail: "test@test.com" },
+        plan: { type: PlanType.EnterpriseAnnually2023 },
+        payment: {
+          paymentMethod: ["card-token", PaymentMethodType.Card],
+          billing: { postalCode: "12345" },
+        },
+      } as SubscriptionInformation;
+
+      const organizationResponse = {
+        name: subscriptionInformation.organization.name,
+        billingEmail: subscriptionInformation.organization.billingEmail,
+        planType: subscriptionInformation.plan.type,
+      } as OrganizationResponse;
+
+      organizationApiService.create.mockResolvedValue(organizationResponse);
+      keyService.makeOrgKey.mockResolvedValue([new EncString("encrypyted-key"), {} as OrgKey]);
+      keyService.makeKeyPair.mockResolvedValue(["key", new EncString("encrypyted-key")]);
+      encryptService.encryptString.mockResolvedValue(new EncString("collection-encrypyted"));
+
+      //Act
+      const response = await sut.purchaseSubscription(subscriptionInformation);
+
+      //Assert
+      expect(organizationApiService.create).toHaveBeenCalledTimes(1);
+      expect(response).toEqual(organizationResponse);
+    });
+
+    it("given organization creation fails, then it throws an error", async () => {
+      // Arrange
+      const subscriptionInformation = {
+        organization: { name: "test-business", billingEmail: "test@test.com" },
+        plan: { type: PlanType.EnterpriseAnnually2023 },
+        payment: {
+          paymentMethod: ["card-token", PaymentMethodType.Card],
+          billing: { postalCode: "12345" },
+        },
+      } as SubscriptionInformation;
+
+      organizationApiService.create.mockRejectedValue(new Error("Failed to create organization"));
+      keyService.makeOrgKey.mockResolvedValue([new EncString("encrypted-key"), {} as OrgKey]);
+      keyService.makeKeyPair.mockResolvedValue(["key", new EncString("encrypted-key")]);
+      encryptService.encryptString.mockResolvedValue(new EncString("collection-encrypyted"));
+
+      // Act & Assert
+      await expect(sut.purchaseSubscription(subscriptionInformation)).rejects.toThrow(
+        "Failed to create organization",
       );
     });
 
-    it("returns false when organization belongs to a provider", async () => {
-      configService.getFeatureFlag$.mockReturnValue(of(true));
-      const org = {
-        isProviderUser: true,
-        canEditSubscription: true,
-        productTierType: ProductTierType.Teams,
-      } as Organization;
+    it("given key generation fails, then it throws an error", async () => {
+      // Arrange
+      const subscriptionInformation = {
+        organization: { name: "test-business", billingEmail: "test@test.com" },
+        plan: { type: PlanType.EnterpriseAnnually2023 },
+        payment: {
+          paymentMethod: ["card-token", PaymentMethodType.Card],
+          billing: { postalCode: "12345" },
+        },
+      } as SubscriptionInformation;
 
-      const actual = await firstValueFrom(sut.isBreadcrumbingPoliciesEnabled$(org));
-      expect(actual).toBe(false);
-    });
+      keyService.makeOrgKey.mockRejectedValue(new Error("Key generation failed"));
 
-    it("returns false when cannot edit subscription", async () => {
-      configService.getFeatureFlag$.mockReturnValue(of(true));
-      const org = {
-        isProviderUser: false,
-        canEditSubscription: false,
-        productTierType: ProductTierType.Teams,
-      } as Organization;
-
-      const actual = await firstValueFrom(sut.isBreadcrumbingPoliciesEnabled$(org));
-      expect(actual).toBe(false);
-    });
-
-    it.each([
-      ["Teams", ProductTierType.Teams],
-      ["TeamsStarter", ProductTierType.TeamsStarter],
-    ])("returns true when all conditions are met with %s tier", async (_, productTierType) => {
-      configService.getFeatureFlag$.mockReturnValue(of(true));
-      const org = {
-        isProviderUser: false,
-        canEditSubscription: true,
-        productTierType: productTierType,
-      } as Organization;
-
-      const actual = await firstValueFrom(sut.isBreadcrumbingPoliciesEnabled$(org));
-      expect(actual).toBe(true);
-      expect(configService.getFeatureFlag$).toHaveBeenCalledWith(
-        FeatureFlag.PM12276_BreadcrumbEventLogs,
+      // Act & Assert
+      await expect(sut.purchaseSubscription(subscriptionInformation)).rejects.toThrow(
+        "Key generation failed",
       );
     });
 
-    it("returns false when product tier is not supported", async () => {
-      configService.getFeatureFlag$.mockReturnValue(of(true));
-      const org = {
-        isProviderUser: false,
-        canEditSubscription: true,
-        productTierType: ProductTierType.Enterprise,
-      } as Organization;
+    it("given an invalid plan type, then it throws an error", async () => {
+      // Arrange
+      const subscriptionInformation = {
+        organization: { name: "test-business", billingEmail: "test@test.com" },
+        plan: { type: -1 as unknown as PlanType },
+        payment: {
+          paymentMethod: ["card-token", PaymentMethodType.Card],
+          billing: { postalCode: "12345" },
+        },
+      } as SubscriptionInformation;
 
-      const actual = await firstValueFrom(sut.isBreadcrumbingPoliciesEnabled$(org));
-      expect(actual).toBe(false);
+      // Act & Assert
+      await expect(sut.purchaseSubscription(subscriptionInformation)).rejects.toThrow();
+    });
+  });
+
+  describe("purchaseSubscriptionNoPaymentMethod()", () => {
+    it("given valid subscription information, then it returns successful response", async () => {
+      //Arrange
+      const subscriptionInformation = {
+        organization: { name: "test-business", billingEmail: "test@test.com" },
+        plan: { type: PlanType.EnterpriseAnnually2023 },
+      } as SubscriptionInformation;
+
+      const organizationResponse = {
+        name: subscriptionInformation.organization.name,
+        plan: { type: subscriptionInformation.plan.type },
+        planType: subscriptionInformation.plan.type,
+      } as OrganizationResponse;
+
+      organizationApiService.createWithoutPayment.mockResolvedValue(organizationResponse);
+      keyService.makeOrgKey.mockResolvedValue([new EncString("encrypted-key"), {} as OrgKey]);
+      keyService.makeKeyPair.mockResolvedValue(["key", new EncString("encrypted-key")]);
+      encryptService.encryptString.mockResolvedValue(new EncString("collection-encrypted"));
+
+      //Act
+      const response = await sut.purchaseSubscriptionNoPaymentMethod(subscriptionInformation);
+
+      //Assert
+      expect(organizationApiService.createWithoutPayment).toHaveBeenCalledTimes(1);
+      expect(response).toEqual(organizationResponse);
     });
 
-    it("handles all conditions false correctly", async () => {
-      configService.getFeatureFlag$.mockReturnValue(of(false));
-      const org = {
-        isProviderUser: true,
-        canEditSubscription: false,
-        productTierType: ProductTierType.Free,
-      } as Organization;
+    it("given organization creation fails without payment method, then it throws an error", async () => {
+      const subscriptionInformation = {
+        organization: { name: "test-business", billingEmail: "test@test.com" },
+        plan: { type: PlanType.EnterpriseAnnually2023 },
+      } as SubscriptionInformation;
 
-      const actual = await firstValueFrom(sut.isBreadcrumbingPoliciesEnabled$(org));
-      expect(actual).toBe(false);
+      organizationApiService.createWithoutPayment.mockRejectedValue(new Error("Creation failed"));
+      keyService.makeOrgKey.mockResolvedValue([new EncString("encrypted-key"), {} as OrgKey]);
+      keyService.makeKeyPair.mockResolvedValue(["key", new EncString("encrypted-key")]);
+      encryptService.encryptString.mockResolvedValue(new EncString("collection-encrypted"));
+
+      await expect(
+        sut.purchaseSubscriptionNoPaymentMethod(subscriptionInformation),
+      ).rejects.toThrow("Creation failed");
     });
 
-    it("verifies feature flag is only called once", async () => {
-      configService.getFeatureFlag$.mockReturnValue(of(false));
-      const org = {
-        isProviderUser: false,
-        canEditSubscription: true,
-        productTierType: ProductTierType.Teams,
-      } as Organization;
+    it("given key generation fails, then it throws an error", async () => {
+      const subscriptionInformation = {
+        organization: { name: "test-business", billingEmail: "test@test.com" },
+        plan: { type: PlanType.EnterpriseAnnually2023 },
+      } as SubscriptionInformation;
 
-      await firstValueFrom(sut.isBreadcrumbingPoliciesEnabled$(org));
-      expect(configService.getFeatureFlag$).toHaveBeenCalledTimes(1);
+      keyService.makeOrgKey.mockRejectedValue(new Error("Key generation failed"));
+      keyService.makeKeyPair.mockResolvedValue(["key", new EncString("encrypted-key")]);
+
+      await expect(
+        sut.purchaseSubscriptionNoPaymentMethod(subscriptionInformation),
+      ).rejects.toThrow("Key generation failed");
+    });
+  });
+
+  describe("startFree()", () => {
+    it("given valid free plan information, then it creates a free organization", async () => {
+      const subscriptionInformation = {
+        organization: { name: "test-business", billingEmail: "test@test.com" },
+        plan: { type: PlanType.Free },
+      } as SubscriptionInformation;
+
+      const organizationResponse = {
+        name: subscriptionInformation.organization.name,
+        billingEmail: subscriptionInformation.organization.billingEmail,
+        planType: subscriptionInformation.plan.type,
+      } as OrganizationResponse;
+
+      organizationApiService.create.mockResolvedValue(organizationResponse);
+      keyService.makeOrgKey.mockResolvedValue([new EncString("encrypyted-key"), {} as OrgKey]);
+      keyService.makeKeyPair.mockResolvedValue(["key", new EncString("encrypyted-key")]);
+      encryptService.encryptString.mockResolvedValue(new EncString("collection-encrypyted"));
+
+      //Act
+      const response = await sut.startFree(subscriptionInformation);
+
+      //Assert
+      expect(organizationApiService.create).toHaveBeenCalledTimes(1);
+      expect(response).toEqual(organizationResponse);
+    });
+
+    it("given key generation fails, then it throws an error", async () => {
+      const subscriptionInformation = {
+        organization: { name: "test-business", billingEmail: "test@test.com" },
+        plan: { type: PlanType.Free },
+      } as SubscriptionInformation;
+
+      keyService.makeOrgKey.mockRejectedValue(new Error("Key generation failed"));
+      keyService.makeKeyPair.mockResolvedValue(["key", new EncString("encrypted-key")]);
+
+      await expect(sut.startFree(subscriptionInformation)).rejects.toThrow("Key generation failed");
+    });
+
+    it("given organization creation fails, then it throws an error", async () => {
+      // Arrange
+      const subscriptionInformation = {
+        organization: { name: "test-business", billingEmail: "test@test.com" },
+        plan: { type: PlanType.Free },
+      } as SubscriptionInformation;
+
+      organizationApiService.create.mockRejectedValue(new Error("Failed to create organization"));
+      keyService.makeOrgKey.mockResolvedValue([new EncString("encrypted-key"), {} as OrgKey]);
+      keyService.makeKeyPair.mockResolvedValue(["key", new EncString("encrypted-key")]);
+      encryptService.encryptString.mockResolvedValue(new EncString("collection-encrypyted"));
+      // Act & Assert
+      await expect(sut.startFree(subscriptionInformation)).rejects.toThrow(
+        "Failed to create organization",
+      );
     });
   });
 });

libs/common/src/billing/services/organization-billing.service.ts

@@ -1,10 +1,5 @@
 // FIXME: Update this file to be type safe and remove this and next line
 // @ts-strict-ignore
-import { Observable, of, switchMap } from "rxjs";
-
-import { Organization } from "@bitwarden/common/admin-console/models/domain/organization";
-import { FeatureFlag } from "@bitwarden/common/enums/feature-flag.enum";
-import { ConfigService } from "@bitwarden/common/platform/abstractions/config/config.service";
 // This import has been flagged as unallowed for this class. It may be involved in a circular dependency loop.
 // eslint-disable-next-line no-restricted-imports
 import { KeyService } from "@bitwarden/key-management";
@@ -27,7 +22,7 @@ import {
   PlanInformation,
   SubscriptionInformation,
 } from "../abstractions";
-import { PlanType, ProductTierType } from "../enums";
+import { PlanType } from "../enums";
 import { OrganizationNoPaymentMethodCreateRequest } from "../models/request/organization-no-payment-method-create-request";
 import { PaymentSourceResponse } from "../models/response/payment-source.response";
 
@@ -47,12 +42,11 @@ export class OrganizationBillingService implements OrganizationBillingServiceAbs
     private i18nService: I18nService,
     private organizationApiService: OrganizationApiService,
     private syncService: SyncService,
-    private configService: ConfigService,
   ) {}
 
   async getPaymentSource(organizationId: string): Promise<PaymentSourceResponse> {
     const paymentMethod = await this.billingApiService.getOrganizationPaymentMethod(organizationId);
-    return paymentMethod.paymentSource;
+    return paymentMethod?.paymentSource;
   }
 
   async purchaseSubscription(subscription: SubscriptionInformation): Promise<OrganizationResponse> {
@@ -229,29 +223,4 @@ export class OrganizationBillingService implements OrganizationBillingServiceAbs
     this.setPaymentInformation(request, subscription.payment);
     await this.billingApiService.restartSubscription(organizationId, request);
   }
-
-  isBreadcrumbingPoliciesEnabled$(organization: Organization): Observable<boolean> {
-    if (organization === null || organization === undefined) {
-      return of(false);
-    }
-
-    return this.configService.getFeatureFlag$(FeatureFlag.PM12276_BreadcrumbEventLogs).pipe(
-      switchMap((featureFlagEnabled) => {
-        if (!featureFlagEnabled) {
-          return of(false);
-        }
-
-        if (organization.isProviderUser || !organization.canEditSubscription) {
-          return of(false);
-        }
-
-        const supportedProducts = [ProductTierType.Teams, ProductTierType.TeamsStarter];
-        const isSupportedProduct = supportedProducts.some(
-          (product) => product === organization.productTierType,
-        );
-
-        return of(isSupportedProduct);
-      }),
-    );
-  }
 }

libs/common/src/enums/feature-flag.enum.ts

@@ -23,7 +23,6 @@ export enum FeatureFlag {
 
   /* Billing */
   TrialPaymentOptional = "PM-8163-trial-payment",
-  PM12276_BreadcrumbEventLogs = "pm-12276-breadcrumbing-for-business-features",
   PM17772_AdminInitiatedSponsorships = "pm-17772-admin-initiated-sponsorships",
   UseOrganizationWarningsService = "use-organization-warnings-service",
   PM21881_ManagePaymentDetailsOutsideCheckout = "pm-21881-manage-payment-details-outside-checkout",
@@ -95,7 +94,6 @@ export const DefaultFeatureFlagValue = {
 
   /* Billing */
   [FeatureFlag.TrialPaymentOptional]: FALSE,
-  [FeatureFlag.PM12276_BreadcrumbEventLogs]: FALSE,
   [FeatureFlag.PM17772_AdminInitiatedSponsorships]: FALSE,
   [FeatureFlag.UseOrganizationWarningsService]: FALSE,
   [FeatureFlag.PM21881_ManagePaymentDetailsOutsideCheckout]: FALSE,