bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-15 07:43:35 +00:00
Code Issues Releases Wiki Activity

[PM-2642] Fix feature flags not working properly when urls load from storage (#5598)

Browse Source 
* fix: feature flags not working properly

Due to race conditions the api url is not set during the first fetch och server config. This causes the config to be fetched from `api.bitwarden.com`. The config is then supposed to be re-fetched when the api url is set by the environment service, but due to a missing line this is not done when the urls are set from storage.

* feat: change to `Observable<void>`
This commit is contained in:
Andreas Coroiu
2023-06-14 14:10:39 +02:00
committed by GitHub
parent 3b708d9311
commit 37010a6414
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libs/common/src/platform/abstractions/environment.service.ts
View File

@@ -18,7 +18,7 @@ export type PayPalConfig = {
};
export abstract class EnvironmentService {
urls: Observable<Urls>;
urls: Observable<void>;
hasBaseUrl: () => boolean;
getNotificationsUrl: () => string;