diff --git a/apps/browser/src/autofill/content/components/notification/confirmation/body.ts b/apps/browser/src/autofill/content/components/notification/confirmation/body.ts index f3dc1117209..c23eb36583d 100644 --- a/apps/browser/src/autofill/content/components/notification/confirmation/body.ts +++ b/apps/browser/src/autofill/content/components/notification/confirmation/body.ts @@ -59,7 +59,6 @@ export function NotificationConfirmationBody({ `; } -// Allow sharing of styles between notifications (@TODO isolate structural/presentational component layer) export const iconContainerStyles = (error?: string | boolean) => css` > svg { width: ${!error ? "50px" : "40px"}; diff --git a/apps/browser/src/autofill/content/components/notification/confirmation/container.ts b/apps/browser/src/autofill/content/components/notification/confirmation/container.ts index b824d88a994..61b8ad9cd1e 100644 --- a/apps/browser/src/autofill/content/components/notification/confirmation/container.ts +++ b/apps/browser/src/autofill/content/components/notification/confirmation/container.ts @@ -113,9 +113,14 @@ function getConfirmationMessage(i18n: I18n, type?: NotificationType, error?: str if (error) { return i18n.saveFailureDetails; } + + /* @TODO This partial string return and later concatenation with the cipher name is needed + * to handle cipher name overflow cases, but is risky for i18n concerns. Fix concatenation + * with cipher name overflow when a tag replacement solution is available. + */ return type === NotificationTypes.Add - ? i18n.loginSaveConfirmation - : i18n.loginUpdatedConfirmation; + ? i18n.notificationLoginSaveConfirmation + : i18n.notificationLoginUpdatedConfirmation; } function getHeaderMessage(i18n: I18n, type?: NotificationType, error?: string) { diff --git a/apps/browser/src/autofill/content/components/notification/confirmation/footer.ts b/apps/browser/src/autofill/content/components/notification/confirmation/footer.ts index fe65c61a63d..bd2e9480d56 100644 --- a/apps/browser/src/autofill/content/components/notification/confirmation/footer.ts +++ b/apps/browser/src/autofill/content/components/notification/confirmation/footer.ts @@ -4,9 +4,9 @@ import { html } from "lit"; import { Theme } from "@bitwarden/common/platform/enums"; import { ActionButton } from "../../buttons/action-button"; -import { AdditionalTasksButtonContent } from "../../buttons/additional-tasks/button-content"; import { I18n } from "../../common-types"; -import { notificationFooterStyles } from "../footer"; +import { spacing, themes } from "../../constants/styles"; +import { ExternalLink } from "../../icons"; export type NotificationConfirmationFooterProps = { i18n: I18n; @@ -22,7 +22,7 @@ export function NotificationConfirmationFooter({ const primaryButtonText = i18n.nextSecurityTaskAction; return html` -