bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-12 06:13:38 +00:00
Code Issues Releases Wiki Activity

only count critical apps with at-risk passwords (#17239)

Browse Source
This commit is contained in:
Alex
2025-11-06 09:11:36 -05:00
committed by GitHub
parent dc56cc80eb
commit 3845ef388c
2 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
bitwarden_license/bit-web/src/app/dirt/access-intelligence/activity/application-review-dialog/new-applications-dialog.component.html
View File

@@ -32,8 +32,8 @@
@if (currentView() === DialogView.AssignTasks) { @if (currentView() === DialogView.AssignTasks) {
<dirt-assign-tasks-view <dirt-assign-tasks-view
[criticalApplicationsCount]="selectedApplications().size" [criticalApplicationsCount]="atRiskCriticalApplicationsCount()"
[totalApplicationsCount]="this.dialogParams.newApplications.length" [totalApplicationsCount]="totalCriticalApplicationsCount()"
[atRiskCriticalMembersCount]="atRiskCriticalMembersCount()" [atRiskCriticalMembersCount]="atRiskCriticalMembersCount()"
> >
</dirt-assign-tasks-view> </dirt-assign-tasks-view>

13
bitwarden_license/bit-web/src/app/dirt/access-intelligence/activity/application-review-dialog/new-applications-dialog.component.ts
View File

@@ -93,8 +93,8 @@ export class NewApplicationsDialogComponent {
protected readonly selectedApplications = signal<Set<string>>(new Set()); protected readonly selectedApplications = signal<Set<string>>(new Set());
// Assign tasks variables // Assign tasks variables
readonly criticalApplicationsCount = signal<number>(0); readonly atRiskCriticalApplicationsCount = signal<number>(0);
readonly totalApplicationsCount = signal<number>(0); readonly totalCriticalApplicationsCount = signal<number>(0);
readonly atRiskCriticalMembersCount = signal<number>(0); readonly atRiskCriticalMembersCount = signal<number>(0);
readonly saving = signal<boolean>(false); readonly saving = signal<boolean>(false);
@@ -169,6 +169,15 @@ export class NewApplicationsDialogComponent {
this.selectedApplications().has(newApp.applicationName), this.selectedApplications().has(newApp.applicationName),
); );
// Count only critical applications that have at-risk passwords
const atRiskCriticalApplicationsCount = onlyNewCriticalApplications.filter(
(app) => app.atRiskPasswordCount > 0,
).length;
this.atRiskCriticalApplicationsCount.set(atRiskCriticalApplicationsCount);
// Total number of selected critical applications
this.totalCriticalApplicationsCount.set(onlyNewCriticalApplications.length);
const atRiskCriticalMembersCount = getUniqueMembers( const atRiskCriticalMembersCount = getUniqueMembers(
onlyNewCriticalApplications.flatMap((x) => x.atRiskMemberDetails), onlyNewCriticalApplications.flatMap((x) => x.atRiskMemberDetails),
).length; ).length;