From 39f475cc95ad1f0e2dc1f4b1393cd0a62059e003 Mon Sep 17 00:00:00 2001
From: Tom <ttalty@bitwarden.com>
Date: Mon, 9 Dec 2024 13:01:02 -0500
Subject: [PATCH] Fixing password health tests

---
 .../services/password-health.service.spec.ts  | 86 +------------------
 1 file changed, 1 insertion(+), 85 deletions(-)

diff --git a/bitwarden_license/bit-common/src/tools/reports/risk-insights/services/password-health.service.spec.ts b/bitwarden_license/bit-common/src/tools/reports/risk-insights/services/password-health.service.spec.ts
index c0f77abeb79..b536fc74f05 100644
--- a/bitwarden_license/bit-common/src/tools/reports/risk-insights/services/password-health.service.spec.ts
+++ b/bitwarden_license/bit-common/src/tools/reports/risk-insights/services/password-health.service.spec.ts
@@ -3,18 +3,15 @@ import { TestBed } from "@angular/core/testing";
 import { AuditService } from "@bitwarden/common/abstractions/audit.service";
 import { PasswordStrengthServiceAbstraction } from "@bitwarden/common/tools/password-strength";
 import { CipherService } from "@bitwarden/common/vault/abstractions/cipher.service";
-import { CipherView } from "@bitwarden/common/vault/models/view/cipher.view";
 
 import { mockCiphers } from "./ciphers.mock";
 import { MemberCipherDetailsApiService } from "./member-cipher-details-api.service";
 import { mockMemberCipherDetails } from "./member-cipher-details-api.service.spec";
 import { PasswordHealthService } from "./password-health.service";
 
+// TODO: Remove password-health report service after PR-15498 completion
 describe("PasswordHealthService", () => {
   let service: PasswordHealthService;
-  let cipherService: CipherService;
-  let memberCipherDetailsApiService: MemberCipherDetailsApiService;
-
   beforeEach(() => {
     TestBed.configureTestingModule({
       providers: [
@@ -51,8 +48,6 @@ describe("PasswordHealthService", () => {
     });
 
     service = TestBed.inject(PasswordHealthService);
-    cipherService = TestBed.inject(CipherService);
-    memberCipherDetailsApiService = TestBed.inject(MemberCipherDetailsApiService);
   });
 
   it("should be created", () => {
@@ -67,83 +62,4 @@ describe("PasswordHealthService", () => {
     expect(service.exposedPasswordMap.size).toBe(0);
     expect(service.totalMembersMap.size).toBe(0);
   });
-
-  describe("generateReport", () => {
-    beforeEach(async () => {
-      await service.generateReport();
-    });
-
-    it("should fetch all ciphers for the organization", () => {
-      expect(cipherService.getAllFromApiForOrganization).toHaveBeenCalledWith("org1");
-    });
-
-    it("should fetch member cipher details", () => {
-      expect(memberCipherDetailsApiService.getMemberCipherDetails).toHaveBeenCalledWith("org1");
-    });
-
-    it("should populate reportCiphers with ciphers that have issues", () => {
-      expect(service.reportCiphers.length).toBeGreaterThan(0);
-    });
-
-    it("should detect weak passwords", () => {
-      expect(service.passwordStrengthMap.size).toBeGreaterThan(0);
-      expect(service.passwordStrengthMap.get("cbea34a8-bde4-46ad-9d19-b05001228ab1")).toEqual([
-        "veryWeak",
-        "danger",
-      ]);
-      expect(service.passwordStrengthMap.get("cbea34a8-bde4-46ad-9d19-b05001228ab2")).toEqual([
-        "veryWeak",
-        "danger",
-      ]);
-      expect(service.passwordStrengthMap.get("cbea34a8-bde4-46ad-9d19-b05001228cd3")).toEqual([
-        "veryWeak",
-        "danger",
-      ]);
-    });
-
-    it("should detect reused passwords", () => {
-      expect(service.passwordUseMap.get("123")).toBe(3);
-    });
-
-    it("should detect exposed passwords", () => {
-      expect(service.exposedPasswordMap.size).toBeGreaterThan(0);
-      expect(service.exposedPasswordMap.get("cbea34a8-bde4-46ad-9d19-b05001228ab1")).toBe(100);
-    });
-
-    it("should calculate total members per cipher", () => {
-      expect(service.totalMembersMap.size).toBeGreaterThan(0);
-      expect(service.totalMembersMap.get("cbea34a8-bde4-46ad-9d19-b05001228ab1")).toBe(2);
-      expect(service.totalMembersMap.get("cbea34a8-bde4-46ad-9d19-b05001228ab2")).toBe(4);
-      expect(service.totalMembersMap.get("cbea34a8-bde4-46ad-9d19-b05001228cd3")).toBe(5);
-      expect(service.totalMembersMap.get("cbea34a8-bde4-46ad-9d19-b05001227nm5")).toBe(4);
-      expect(service.totalMembersMap.get("cbea34a8-bde4-46ad-9d19-b05001227nm7")).toBe(1);
-      expect(service.totalMembersMap.get("cbea34a8-bde4-46ad-9d19-b05001228xy4")).toBe(6);
-    });
-  });
-
-  describe("findWeakPassword", () => {
-    it("should add weak passwords to passwordStrengthMap", () => {
-      const weakCipher = mockCiphers.find((c) => c.login?.password === "123") as CipherView;
-      service.findWeakPassword(weakCipher);
-      expect(service.passwordStrengthMap.get(weakCipher.id)).toEqual(["veryWeak", "danger"]);
-    });
-  });
-
-  describe("findReusedPassword", () => {
-    it("should detect password reuse", () => {
-      mockCiphers.forEach((cipher) => {
-        service.findReusedPassword(cipher as CipherView);
-      });
-      const reuseCounts = Array.from(service.passwordUseMap.values()).filter((count) => count > 1);
-      expect(reuseCounts.length).toBeGreaterThan(0);
-    });
-  });
-
-  describe("findExposedPassword", () => {
-    it("should add exposed passwords to exposedPasswordMap", async () => {
-      const exposedCipher = mockCiphers.find((c) => c.login?.password === "123") as CipherView;
-      await service.findExposedPassword(exposedCipher);
-      expect(service.exposedPasswordMap.get(exposedCipher.id)).toBe(100);
-    });
-  });
 });