bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-17 16:53:34 +00:00
Code Issues Releases Wiki Activity

[PM-19215] Fix Firefox extension biometric unlock autoprompt (#14254)

Browse Source 
* Remove restriction from account security component

* Add the ability to manage pop-out to the LockComponentService

* Have the Firefox extension pop-out on biometric auto-prompt unlock
This commit is contained in:
Thomas Avery
2025-04-21 14:08:09 -05:00
committed by GitHub
parent 143473927e
commit 3a8045d7d0
11 changed files with 166 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
apps/desktop/src/key-management/lock/services/desktop-lock-component.service.spec.ts
View File

@@ -104,6 +104,22 @@ describe("DesktopLockComponentService", () => {
});
});
describe("popOutBrowserExtension", () => {
it("throws platform not supported error", () => {
expect(() => service.popOutBrowserExtension()).toThrow(
"Method not supported on this platform.",
);
});
});
describe("closeBrowserExtensionPopout", () => {
it("throws platform not supported error", () => {
expect(() => service.closeBrowserExtensionPopout()).toThrow(
"Method not supported on this platform.",
);
});
});
describe("isWindowVisible", () => {
it("returns the window visibility", async () => {
isWindowVisibleMock.mockReturnValue(true);

8
apps/desktop/src/key-management/lock/services/desktop-lock-component.service.ts
View File

@@ -27,6 +27,14 @@ export class DesktopLockComponentService implements LockComponentService {
return null;
}
popOutBrowserExtension(): Promise<void> {
throw new Error("Method not supported on this platform.");
}
closeBrowserExtensionPopout(): void {
throw new Error("Method not supported on this platform.");
}
async isWindowVisible(): Promise<boolean> {
return ipc.platform.isWindowVisible();
}