From 3bb6bfb7532a7e0a0009c47e1c7281ac7950798b Mon Sep 17 00:00:00 2001 From: Cesar Gonzalez Date: Tue, 16 Apr 2024 09:33:11 -0500 Subject: [PATCH] [PM-5189] Refactoring implementation --- .../overlay/pages/menu/autofill-overlay-menu-container.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/apps/browser/src/autofill/overlay/pages/menu/autofill-overlay-menu-container.ts b/apps/browser/src/autofill/overlay/pages/menu/autofill-overlay-menu-container.ts index e0f5e14dc49..971a5a92d22 100644 --- a/apps/browser/src/autofill/overlay/pages/menu/autofill-overlay-menu-container.ts +++ b/apps/browser/src/autofill/overlay/pages/menu/autofill-overlay-menu-container.ts @@ -109,7 +109,7 @@ export class AutofillOverlayMenuContainer { return; } - if (event.source === globalThis.parent) { + if (this.isMessageFromParentWindow(event)) { this.postMessageToOverlayPage(message); return; } @@ -122,13 +122,17 @@ export class AutofillOverlayMenuContainer { return true; } - if (globalThis.parent === event.source) { + if (this.isMessageFromParentWindow(event)) { return false; } return !this.isMessageFromOverlayPageIframe(event); } + private isMessageFromParentWindow(event: MessageEvent): boolean { + return globalThis.parent === event.source; + } + private isMessageFromOverlayPageIframe(event: MessageEvent): boolean { if (!this.overlayPageIframe) { return false;