bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-10 13:23:34 +00:00
Code Issues Releases Wiki Activity

[PM-27854] close dialog when redirecting to premium page (#17243)

Browse Source
This commit is contained in:
Kyle Denney
2025-11-11 10:32:07 -06:00
committed by GitHub
parent 84340cba5c
commit 3c1262c999
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
apps/web/src/app/vault/services/web-premium-upgrade-prompt.service.spec.ts
View File

@@ -187,6 +187,13 @@ describe("WebVaultPremiumUpgradePromptService", () => {
expect(routerMock.navigate).toHaveBeenCalledWith(["settings/subscription/premium"]); expect(routerMock.navigate).toHaveBeenCalledWith(["settings/subscription/premium"]);
expect(dialogServiceMock.openSimpleDialog).not.toHaveBeenCalled(); expect(dialogServiceMock.openSimpleDialog).not.toHaveBeenCalled();
}); });
it("should close dialog when redirecting to subscription page", async () => {
await service.promptForPremium();
expect(dialogRefMock.close).toHaveBeenCalledWith(VaultItemDialogResult.PremiumUpgrade);
expect(routerMock.navigate).toHaveBeenCalledWith(["settings/subscription/premium"]);
});
}); });
describe("when not self-hosted", () => { describe("when not self-hosted", () => {

3
apps/web/src/app/vault/services/web-premium-upgrade-prompt.service.ts
View File

@@ -107,6 +107,9 @@ export class WebVaultPremiumUpgradePromptService implements PremiumUpgradePrompt
private async redirectToSubscriptionPage() { private async redirectToSubscriptionPage() {
await this.router.navigate([this.subscriptionPageRoute]); await this.router.navigate([this.subscriptionPageRoute]);
if (this.dialog) {
this.dialog.close(VaultItemDialogResult.PremiumUpgrade);
}
} }
private async openUpgradeDialog(account: Account) { private async openUpgradeDialog(account: Account) {