From 3c47eb8900a06420cbaf07ede3918c84eb350095 Mon Sep 17 00:00:00 2001 From: Vicki League Date: Wed, 25 Jun 2025 15:55:06 -0400 Subject: [PATCH] fixes for form-field module --- libs/components/src/form-field/error-summary.component.ts | 2 +- libs/components/src/form-field/error.component.ts | 2 +- libs/components/src/form-field/form-field.stories.ts | 2 +- libs/components/src/form-field/prefix.directive.ts | 6 +++--- libs/components/src/form-field/suffix.directive.ts | 6 +++--- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/libs/components/src/form-field/error-summary.component.ts b/libs/components/src/form-field/error-summary.component.ts index 9750f9ee556..b5062a46e4d 100644 --- a/libs/components/src/form-field/error-summary.component.ts +++ b/libs/components/src/form-field/error-summary.component.ts @@ -18,7 +18,7 @@ import { I18nPipe } from "@bitwarden/ui-common"; imports: [I18nPipe], }) export class BitErrorSummary { - readonly formGroup = input(undefined); + readonly formGroup = input(); get errorCount(): number { return this.getErrorCount(this.formGroup()); diff --git a/libs/components/src/form-field/error.component.ts b/libs/components/src/form-field/error.component.ts index 8e8101b8709..f21ff77cace 100644 --- a/libs/components/src/form-field/error.component.ts +++ b/libs/components/src/form-field/error.component.ts @@ -18,7 +18,7 @@ let nextId = 0; export class BitErrorComponent { @HostBinding() id = `bit-error-${nextId++}`; - readonly error = input<[string, any]>(undefined); + readonly error = input<[string, any]>(); constructor(private i18nService: I18nService) {} diff --git a/libs/components/src/form-field/form-field.stories.ts b/libs/components/src/form-field/form-field.stories.ts index 738ac96bf76..7db28f5860a 100644 --- a/libs/components/src/form-field/form-field.stories.ts +++ b/libs/components/src/form-field/form-field.stories.ts @@ -87,8 +87,8 @@ export default { SectionComponent, TextFieldModule, BadgeModule, + A11yTitleDirective, ], - declarations: [A11yTitleDirective], providers: [ { provide: I18nService, diff --git a/libs/components/src/form-field/prefix.directive.ts b/libs/components/src/form-field/prefix.directive.ts index b9ba6d61feb..6dcff2f7ca5 100644 --- a/libs/components/src/form-field/prefix.directive.ts +++ b/libs/components/src/form-field/prefix.directive.ts @@ -1,15 +1,15 @@ -import { Directive, input, OnInit, Optional } from "@angular/core"; +import { Directive, OnInit, Optional } from "@angular/core"; import { BitIconButtonComponent } from "../icon-button/icon-button.component"; @Directive({ selector: "[bitPrefix]", host: { - "[attr.class]": "classList()", + "[class]": "classList()", }, }) export class BitPrefixDirective implements OnInit { - readonly classList = input(["tw-text-muted"]); + readonly classList = ["tw-text-muted"]; constructor(@Optional() private iconButtonComponent: BitIconButtonComponent) {} diff --git a/libs/components/src/form-field/suffix.directive.ts b/libs/components/src/form-field/suffix.directive.ts index 8afda8761ec..c892ebc51eb 100644 --- a/libs/components/src/form-field/suffix.directive.ts +++ b/libs/components/src/form-field/suffix.directive.ts @@ -1,15 +1,15 @@ -import { Directive, input, OnInit, Optional } from "@angular/core"; +import { Directive, OnInit, Optional } from "@angular/core"; import { BitIconButtonComponent } from "../icon-button/icon-button.component"; @Directive({ selector: "[bitSuffix]", host: { - "[attr.class]": "classList()", + "[class]": "classList", }, }) export class BitSuffixDirective implements OnInit { - readonly classList = input(["tw-text-muted"]); + readonly classList = ["tw-text-muted"]; constructor(@Optional() private iconButtonComponent: BitIconButtonComponent) {}