bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-12 14:23:32 +00:00
Code Issues Releases Wiki Activity

Deprecated broadcaster (#5461)

Browse Source
This commit is contained in:
Oscar Hinton
2023-05-17 12:27:27 +02:00
committed by GitHub
parent aa2da57139
commit 3da7fc7cb3
3 changed files with 24 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
apps/desktop/src/app/app.component.ts
View File

@@ -156,6 +156,12 @@ export class AppComponent implements OnInit, OnDestroy {
window.onkeypress = () => this.recordActivity(); window.onkeypress = () => this.recordActivity();
}); });
/// ############ DEPRECATED ############
/// Please do not use the AppComponent to send events between services.
///
/// Services that depends on other services, should do so through Dependency Injection
/// and subscribe to events through that service observable.
///
this.broadcasterService.subscribe(BroadcasterSubscriptionId, async (message: any) => { this.broadcasterService.subscribe(BroadcasterSubscriptionId, async (message: any) => {
this.ngZone.run(async () => { this.ngZone.run(async () => {
switch (message.command) { switch (message.command) {

6
apps/web/src/app/app.component.ts
View File

@@ -98,6 +98,12 @@ export class AppComponent implements OnDestroy, OnInit {
window.onkeypress = () => this.recordActivity(); window.onkeypress = () => this.recordActivity();
}); });
/// ############ DEPRECATED ############
/// Please do not use the AppComponent to send events between services.
///
/// Services that depends on other services, should do so through Dependency Injection
/// and subscribe to events through that service observable.
///
this.broadcasterService.subscribe(BroadcasterSubscriptionId, async (message: any) => { this.broadcasterService.subscribe(BroadcasterSubscriptionId, async (message: any) => {
this.ngZone.run(async () => { this.ngZone.run(async () => {
switch (message.command) { switch (message.command) {

12
libs/common/src/abstractions/broadcaster.service.ts
View File

@@ -2,8 +2,20 @@ export interface MessageBase {
command: string; command: string;
} }
/**
* @deprecated Use the observable from the appropriate service instead.
*/
export abstract class BroadcasterService { export abstract class BroadcasterService {
/**
* @deprecated Use the observable from the appropriate service instead.
*/
send: (message: MessageBase, id?: string) => void; send: (message: MessageBase, id?: string) => void;
/**
* @deprecated Use the observable from the appropriate service instead.
*/
subscribe: (id: string, messageCallback: (message: MessageBase) => void) => void; subscribe: (id: string, messageCallback: (message: MessageBase) => void) => void;
/**
* @deprecated Use the observable from the appropriate service instead.
*/
unsubscribe: (id: string) => void; unsubscribe: (id: string) => void;
} }