bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-23 11:43:46 +00:00
Code Issues Releases Wiki Activity

[BEEEP][PM-255518] Use tracing for improved observability (#16321)

Browse Source 
* [BEEEP][PM-255518] Use tracing for improved observability

* feedback dani-garcia: use DefaultVisitor

* set default log level

* convert printlns in objc crate

* convert printlns in autotype crate

* convert printlns in autostart crate

* convert printlns in core/password crate

* convert printlns in core/biometric crate

* convert printlns in napi crate

* convert log usage in macos provider crate

* convert existing log macros to tracing

* fix the cargo.toml sort lint errors

* Revert "fix the cargo.toml sort lint errors"

This reverts commit fd149ab697.

* fix the sort lint using correct cargo sort version

* feedback coltonhurst: more comments/clarity on behavior

* revert changes to ssh_agent
This commit is contained in:
neuronull
2025-09-22 09:56:23 -06:00
committed by GitHub
parent 3bbc6c564c
commit 3f14fdc62d
17 changed files with 226 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
apps/desktop/desktop_native/objc/src/lib.rs
View File

@@ -66,6 +66,8 @@ impl Drop for ObjCString {
mod objc {
use std::os::raw::c_void;
use tracing::error;
use super::*;
unsafe extern "C" {
@@ -79,8 +81,9 @@ mod objc {
let value: String = match value.try_into() {
Ok(value) => value,
Err(e) => {
println!(
"Error: Failed to convert ObjCString to Rust string during commandReturn: {e}"
error!(
error = %e,
"Error: Failed to convert ObjCString to Rust string during commandReturn"
);
return false;
@@ -90,7 +93,9 @@ mod objc {
match context.send(value) {
Ok(_) => 0,
Err(e) => {
println!("Error: Failed to return ObjCString from ObjC code to Rust code: {e}");
error!(
error = %e,
"Error: Failed to return ObjCString from ObjC code to Rust code");
return false;
}