From 40606ee8af2d13fd7198beef191fcd7e2cd2492c Mon Sep 17 00:00:00 2001 From: Jordan Aasen <166539328+jaasen-livefront@users.noreply.github.com> Date: Fri, 24 Jan 2025 11:09:04 -0800 Subject: [PATCH] [PM-15943] - Revert When filling a password, the extension flickers (#13061) * Revert "use requestAnimationFrame instead of arbitrary timeout" This reverts commit 09a236b1e71984bdea661eb28066b4a72101d3e3. * Revert "fix failing test" This reverts commit cb24266e9df0b777061233c4636eacb561a4bac8. --- .../vault/popup/services/vault-popup-autofill.service.spec.ts | 4 ++-- .../src/vault/popup/services/vault-popup-autofill.service.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/apps/browser/src/vault/popup/services/vault-popup-autofill.service.spec.ts b/apps/browser/src/vault/popup/services/vault-popup-autofill.service.spec.ts index 5c9cf57f475..2dad1e3034c 100644 --- a/apps/browser/src/vault/popup/services/vault-popup-autofill.service.spec.ts +++ b/apps/browser/src/vault/popup/services/vault-popup-autofill.service.spec.ts @@ -280,10 +280,10 @@ describe("VaultPopupAutofillService", () => { it("should close popup after a timeout for chromium browsers", async () => { mockPlatformUtilsService.isFirefox.mockReturnValue(false); - jest.spyOn(global, "requestAnimationFrame"); + jest.spyOn(global, "setTimeout"); await service.doAutofill(mockCipher); jest.advanceTimersByTime(50); - expect(requestAnimationFrame).toHaveBeenCalled(); + expect(setTimeout).toHaveBeenCalledTimes(1); expect(BrowserApi.closePopup).toHaveBeenCalled(); }); diff --git a/apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts b/apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts index c0221af75b6..ff282d7a6d0 100644 --- a/apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts +++ b/apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts @@ -280,7 +280,7 @@ export class VaultPopupAutofillService { } // Slight delay to fix bug in Chromium browsers where popup closes without copying totp to clipboard - requestAnimationFrame(() => BrowserApi.closePopup(window)); + setTimeout(() => BrowserApi.closePopup(window), 50); } /**