From 4150ad09fa40b9347f346a340d4cc6fc53052e1e Mon Sep 17 00:00:00 2001 From: rr-bw <102181210+rr-bw@users.noreply.github.com> Date: Wed, 12 Nov 2025 10:31:14 -0800 Subject: [PATCH] add try/catch when calling receivedPendingAuthRequest() --- .../internal/default-server-notifications.service.ts | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/libs/common/src/platform/server-notifications/internal/default-server-notifications.service.ts b/libs/common/src/platform/server-notifications/internal/default-server-notifications.service.ts index 72faf012d95..32ce46d84f5 100644 --- a/libs/common/src/platform/server-notifications/internal/default-server-notifications.service.ts +++ b/libs/common/src/platform/server-notifications/internal/default-server-notifications.service.ts @@ -296,10 +296,14 @@ export class DefaultServerNotificationsService implements ServerNotificationsSer case NotificationType.AuthRequest: { // Only Extension and Desktop implement the AuthRequestAnsweringService if (this.authRequestAnsweringService.receivedPendingAuthRequest) { - await this.authRequestAnsweringService.receivedPendingAuthRequest( - notification.payload.userId, - notification.payload.id, - ); + try { + await this.authRequestAnsweringService.receivedPendingAuthRequest( + notification.payload.userId, + notification.payload.id, + ); + } catch (error) { + this.logService.error(`Failed to process auth request notification: ${error}`); + } } else { // This call is necessary for Web, which uses a NoopAuthRequestAnsweringService // that does not have a receivedPendingAuthRequest() method