bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-01-06 02:23:44 +00:00
Code Issues Releases Wiki Activity

chore(captcha): [PM-15162] Remove handling of captcha enforcement and bypass token

Browse Source 
* Removed captcha references.

* Removed connectors from webpack

* Fixed extra parameter.

* Resolve merge conflicts.

* Fixed extra argument.

* Fixed failing tests.

* Fixed failing test.

* Accessibility cookie cleanup

* Cleaned up accessibility component.

* Deleted old registration endpoint

* Remove unused register request object.

* Fixed merge error that changed font family.

* Fixed formatting from merge.

* Linting
This commit is contained in:
Todd Martin
2025-05-09 10:44:11 -04:00
committed by GitHub
parent 625256b08e
commit 4191bb9533
59 changed files with 56 additions and 977 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
libs/auth/src/common/services/login-strategies/login-strategy.service.spec.ts
View File

@@ -248,7 +248,7 @@ describe("LoginStrategyService", () => {
premium: false,
});
const result = await sut.logInTwoFactor(twoFactorToken, "CAPTCHA");
const result = await sut.logInTwoFactor(twoFactorToken);
expect(result).toBeInstanceOf(AuthResult);
});
@@ -285,7 +285,7 @@ describe("LoginStrategyService", () => {
true,
);
await expect(sut.logInTwoFactor(twoFactorToken, "CAPTCHA")).rejects.toThrow();
await expect(sut.logInTwoFactor(twoFactorToken)).rejects.toThrow();
});
it("throw error on too low kdf config", async () => {

9
libs/auth/src/common/services/login-strategies/login-strategy.service.ts
View File

@@ -242,10 +242,7 @@ export class LoginStrategyService implements LoginStrategyServiceAbstraction {
return result;
}
async logInTwoFactor(
twoFactor: TokenTwoFactorRequest,
captchaResponse: string,
): Promise<AuthResult> {
async logInTwoFactor(twoFactor: TokenTwoFactorRequest): Promise<AuthResult> {
if (!(await this.isSessionValid())) {
throw new Error(this.i18nService.t("sessionTimeout"));
}
@@ -256,10 +253,10 @@ export class LoginStrategyService implements LoginStrategyServiceAbstraction {
}
try {
const result = await strategy.logInTwoFactor(twoFactor, captchaResponse);
const result = await strategy.logInTwoFactor(twoFactor);
// Only clear cache if 2FA token has been accepted, otherwise we need to be able to try again
if (result != null && !result.requiresTwoFactor && !result.requiresCaptcha) {
if (result != null && !result.requiresTwoFactor) {
await this.clearCache();
}
return result;

3
libs/auth/src/common/services/login-strategies/login-strategy.state.spec.ts
View File

@@ -47,7 +47,6 @@ describe("LOGIN_STRATEGY_CACHE_KEY", () => {
actual.password.tokenRequest = new PasswordTokenRequest(
"EMAIL",
"LOCAL_PASSWORD_HASH",
"CAPTCHA_TOKEN",
twoFactorRequest,
deviceRequest,
);
@@ -116,7 +115,7 @@ describe("LOGIN_STRATEGY_CACHE_KEY", () => {
deviceResponse,
deviceRequest,
);
actual.webAuthn.captchaBypassToken = "CAPTCHA_BYPASS_TOKEN";
actual.webAuthn.tokenRequest.setTwoFactor(
new TokenTwoFactorRequest(TwoFactorProviderType.Email, "TOKEN", false),
);