bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-10 21:33:27 +00:00
Code Issues Releases Wiki Activity

[PM-22344] - update response type for shareManyWithServer (#15061)

Browse Source 
* update response type for shareManyWithServer

* build new ListResponse
This commit is contained in:
Jordan Aasen
2025-06-03 13:59:34 -07:00
committed by GitHub
parent 6dabdd73cb
commit 4223a7e2d7
3 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libs/common/src/abstractions/api.service.ts
View File

@@ -208,7 +208,7 @@ export abstract class ApiService {
deleteManyCiphersAdmin: (request: CipherBulkDeleteRequest) => Promise<any>; deleteManyCiphersAdmin: (request: CipherBulkDeleteRequest) => Promise<any>;
putMoveCiphers: (request: CipherBulkMoveRequest) => Promise<any>; putMoveCiphers: (request: CipherBulkMoveRequest) => Promise<any>;
putShareCipher: (id: string, request: CipherShareRequest) => Promise<CipherResponse>; putShareCipher: (id: string, request: CipherShareRequest) => Promise<CipherResponse>;
putShareCiphers: (request: CipherBulkShareRequest) => Promise<CipherResponse[]>; putShareCiphers: (request: CipherBulkShareRequest) => Promise<ListResponse<CipherResponse>>;
putCipherCollections: ( putCipherCollections: (
id: string, id: string,
request: CipherCollectionsRequest, request: CipherCollectionsRequest,

5
libs/common/src/services/api.service.ts
View File

@@ -532,8 +532,9 @@ export class ApiService implements ApiServiceAbstraction {
return new CipherResponse(r); return new CipherResponse(r);
} }
async putShareCiphers(request: CipherBulkShareRequest): Promise<CipherResponse[]> { async putShareCiphers(request: CipherBulkShareRequest): Promise<ListResponse<CipherResponse>> {
return await this.send("PUT", "/ciphers/share", request, true, true); const r = await this.send("PUT", "/ciphers/share", request, true, true);
return new ListResponse<CipherResponse>(r, CipherResponse);
} }
async putCipherCollections( async putCipherCollections(

2
libs/common/src/vault/services/cipher.service.ts
View File

@@ -852,7 +852,7 @@ export class CipherService implements CipherServiceAbstraction {
const request = new CipherBulkShareRequest(encCiphers, collectionIds, userId); const request = new CipherBulkShareRequest(encCiphers, collectionIds, userId);
try { try {
const response = await this.apiService.putShareCiphers(request); const response = await this.apiService.putShareCiphers(request);
const responseMap = new Map(response.map((c) => [c.id, c])); const responseMap = new Map(response.data.map((r) => [r.id, r]));
encCiphers.forEach((cipher) => { encCiphers.forEach((cipher) => {
const matchingCipher = responseMap.get(cipher.id); const matchingCipher = responseMap.get(cipher.id);