bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-13 23:03:32 +00:00
Code Issues Releases Wiki Activity

don't allow 'except password' permissions to view or copy hidden fields (#12899)

Browse Source
This commit is contained in:
Jordan Aasen
2025-01-17 15:04:06 -08:00
committed by GitHub
parent a803e5b411
commit 43a6a93944
3 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
libs/vault/src/cipher-form/components/custom-fields/custom-fields.component.ts
View File

@@ -167,6 +167,10 @@ export class CustomFieldsComponent implements OnInit, AfterViewInit {
); );
}); });
if (!this.cipherFormContainer.originalCipherView?.viewPassword) {
this.customFieldsForm.disable();
}
// Disable the form if in partial-edit mode // Disable the form if in partial-edit mode
// Must happen after the initial fields are populated // Must happen after the initial fields are populated
if (this.cipherFormContainer.config.mode === "partial-edit") { if (this.cipherFormContainer.config.mode === "partial-edit") {

2
libs/vault/src/cipher-view/custom-fields/custom-fields-v2.component.html
View File

@@ -38,6 +38,7 @@
type="button" type="button"
bitIconButton bitIconButton
bitPasswordInputToggle bitPasswordInputToggle
*ngIf="canViewPassword"
(toggledChange)="logHiddenEvent($event)" (toggledChange)="logHiddenEvent($event)"
></button> ></button>
<button <button
@@ -47,6 +48,7 @@
[appCopyClick]="field.value" [appCopyClick]="field.value"
showToast showToast
[valueLabel]="field.name" [valueLabel]="field.name"
*ngIf="canViewPassword"
[appA11yTitle]="'copyCustomField' | i18n: field.name" [appA11yTitle]="'copyCustomField' | i18n: field.name"
(click)="logCopyEvent()" (click)="logCopyEvent()"
></button> ></button>

4
libs/vault/src/cipher-view/custom-fields/custom-fields-v2.component.ts
View File

@@ -59,6 +59,10 @@ export class CustomFieldV2Component implements OnInit {
return this.i18nService.t(linkedType.i18nKey); return this.i18nService.t(linkedType.i18nKey);
} }
get canViewPassword() {
return this.cipher.viewPassword;
}
async logHiddenEvent(hiddenFieldVisible: boolean) { async logHiddenEvent(hiddenFieldVisible: boolean) {
if (hiddenFieldVisible) { if (hiddenFieldVisible) {
await this.eventCollectionService.collect( await this.eventCollectionService.collect(