bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-10 13:23:34 +00:00
Code Issues Releases Wiki Activity

[PS-1840] - fix for covered dropdown on empty vault (#4019)

Browse Source 
* fix for covered dropdown on empty vault

This could be done one of 2-3 ways. I think this might be the least problematic, but could also be done with just changing "position: absolute" to "relative on the ".no-items" class - base.css:461 For some reason, I'm unable to load the spinner to test.

* rename class
This commit is contained in:
DanHillesheim
2022-11-09 09:57:01 -07:00
committed by GitHub
parent c2bf6a6700
commit 4410eb6270
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
apps/browser/src/popup/scss/misc.scss
View File

@@ -135,6 +135,11 @@ p.lead {
border-radius: $border-radius; border-radius: $border-radius;
} }
.select-index-top {
position: relative;
z-index: 100;
}
.sr-only { .sr-only {
position: absolute !important; position: absolute !important;
width: 1px !important; width: 1px !important;

5
apps/browser/src/popup/vault/vault-filter.component.html
View File

@@ -23,7 +23,10 @@
</div> </div>
</header> </header>
<main tabindex="-1" cdk-scrollable> <main tabindex="-1" cdk-scrollable>
<app-vault-select (onVaultSelectionChanged)="vaultFilterChanged()"></app-vault-select> <app-vault-select
(onVaultSelectionChanged)="vaultFilterChanged()"
class="select-index-top"
></app-vault-select>
<div class="no-items" *ngIf="(!ciphers || !ciphers.length) && !showSearching()"> <div class="no-items" *ngIf="(!ciphers || !ciphers.length) && !showSearching()">
<i class="bwi bwi-spinner bwi-spin bwi-3x" *ngIf="!loaded"></i> <i class="bwi bwi-spinner bwi-spin bwi-3x" *ngIf="!loaded"></i>
<ng-container *ngIf="loaded"> <ng-container *ngIf="loaded">