From 44b59714589b261bc3ffdc35560caeaae64a2db8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=9C=A8=20Audrey=20=E2=9C=A8?= Date: Fri, 14 Jun 2024 13:19:51 -0400 Subject: [PATCH] [PM-8857] fix passphrase missing number (#9634) --- .../tools/generator/passphrase/passphrase-generator-strategy.ts | 2 +- .../core/src/strategies/passphrase-generator-strategy.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libs/common/src/tools/generator/passphrase/passphrase-generator-strategy.ts b/libs/common/src/tools/generator/passphrase/passphrase-generator-strategy.ts index 3ed6a1219ce..bf381845704 100644 --- a/libs/common/src/tools/generator/passphrase/passphrase-generator-strategy.ts +++ b/libs/common/src/tools/generator/passphrase/passphrase-generator-strategy.ts @@ -51,7 +51,7 @@ export class PassphraseGeneratorStrategy // select which word gets the number, if any let luckyNumber = -1; if (o.includeNumber) { - luckyNumber = await this.randomizer.uniform(0, o.numWords); + luckyNumber = await this.randomizer.uniform(0, o.numWords - 1); } // generate the passphrase diff --git a/libs/tools/generator/core/src/strategies/passphrase-generator-strategy.ts b/libs/tools/generator/core/src/strategies/passphrase-generator-strategy.ts index 023c9f531d9..7fdadaf8e24 100644 --- a/libs/tools/generator/core/src/strategies/passphrase-generator-strategy.ts +++ b/libs/tools/generator/core/src/strategies/passphrase-generator-strategy.ts @@ -47,7 +47,7 @@ export class PassphraseGeneratorStrategy // select which word gets the number, if any let luckyNumber = -1; if (o.includeNumber) { - luckyNumber = await this.randomizer.uniform(0, o.numWords); + luckyNumber = await this.randomizer.uniform(0, o.numWords - 1); } // generate the passphrase