From 44ed125286a94dae7d084edf0bff9bbaa421530a Mon Sep 17 00:00:00 2001 From: Bernd Schoolmann Date: Thu, 28 Aug 2025 08:44:43 +0200 Subject: [PATCH] Cleanup --- .../os-biometrics-linux-v2.service.ts | 33 ++++++++++--------- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/apps/desktop/src/key-management/biometrics/os-biometrics-linux-v2.service.ts b/apps/desktop/src/key-management/biometrics/os-biometrics-linux-v2.service.ts index 6b873f3a45a..71bbcb3e976 100644 --- a/apps/desktop/src/key-management/biometrics/os-biometrics-linux-v2.service.ts +++ b/apps/desktop/src/key-management/biometrics/os-biometrics-linux-v2.service.ts @@ -1,12 +1,9 @@ import { spawn } from "child_process"; -import { CryptoFunctionService } from "@bitwarden/common/key-management/crypto/abstractions/crypto-function.service"; -import { EncryptService } from "@bitwarden/common/key-management/crypto/abstractions/encrypt.service"; -import { LogService } from "@bitwarden/common/platform/abstractions/log.service"; import { SymmetricCryptoKey } from "@bitwarden/common/platform/models/domain/symmetric-crypto-key"; import { UserId } from "@bitwarden/common/types/guid"; import { biometrics, biometrics_v2, passwords } from "@bitwarden/desktop-napi"; -import { BiometricsStatus, BiometricStateService } from "@bitwarden/key-management"; +import { BiometricsStatus } from "@bitwarden/key-management"; import { isFlatpak, isLinux, isSnapStore } from "../../utils"; @@ -33,26 +30,30 @@ const policyPath = "/usr/share/polkit-1/actions/"; export default class OsBiometricsServiceLinux implements OsBiometricService { private biometricsSystem = biometrics_v2.initBiometricSystem(); - - constructor( - ) {} + + constructor() {} async setBiometricKey(userId: UserId, key: SymmetricCryptoKey): Promise { - biometrics_v2.provideKey(this.biometricsSystem, userId, Buffer.from(key.toEncoded().buffer)); + await biometrics_v2.provideKey( + this.biometricsSystem, + userId, + Buffer.from(key.toEncoded().buffer), + ); } - async deleteBiometricKey(userId: UserId): Promise { - } + async deleteBiometricKey(userId: UserId): Promise {} async getBiometricKey(userId: UserId): Promise { - const hwnd = Buffer.from(""); - const result = await biometrics_v2.unlock(this.biometricsSystem, userId, hwnd); + const result = await biometrics_v2.unlock(this.biometricsSystem, userId, Buffer.from("")); return result ? new SymmetricCryptoKey(Uint8Array.from(result)) : null; } async authenticateBiometric(): Promise { - const hwnd = Buffer.from(""); - return await biometrics_v2.authenticate(this.biometricsSystem, hwnd, "Authenticate to unlock"); + return await biometrics_v2.authenticate( + this.biometricsSystem, + Buffer.from(""), + "Authenticate to unlock", + ); } async supportsBiometrics(): Promise { @@ -101,6 +102,8 @@ export default class OsBiometricsServiceLinux implements OsBiometricService { } async getBiometricsFirstUnlockStatusForUser(userId: UserId): Promise { - return biometrics_v2.unlockAvailable(this.biometricsSystem, userId) ? BiometricsStatus.Available : BiometricsStatus.UnlockNeeded; + return (await biometrics_v2.unlockAvailable(this.biometricsSystem, userId)) + ? BiometricsStatus.Available + : BiometricsStatus.UnlockNeeded; } }