[PM-10294] Remove FC v1 from Clients (#10422)

* chore: remove fc v1 from org.canEditAnyCollection and update callers, refs PM-10294

* chore: remove fc v1 from collectionView.canEdit and update callers, refs PM-10294

* chore: remove fc v1 from organization.canEditAllCiphers and update callers, refs PM-10294

* chore: remove fc v1 from canDeleteAnyCollection, collection views, update callers, refs PM-10294

* chore: remove fc v1 from canEditUser/GroupAccess, refs PM-10294

* chore: remove fc v1 from canViewCollectionInfo, refs PM-10294

* chore: remove fc v1 from account component, refs PM-10294

* fix: remove fc v1 from collections component, refs PM-10294

* fix: update vault-items component, refs PM-10294

* fix: remove fc v1 from collection-dialog and collections components, refs PM-10294

* chore: remove ConfigService from group-add-edit and account components, refs PM-10294

* chore: change canEditAnyCollection to getter and update callers, refs PM-10294

* chore: change canEditUnmanagedCollections to getter and update callers, refs PM-10294

* chore: change canDeleteAnyCollection to getter and update callers, refs PM-10294

* chore: remove deprecated observable and update comments with v1, refs PM-10294

* chore: remove ununsed ConfigService from collection-dialog component, refs PM-10294

* chore: remove final fc v1 ref for vault-collection-row, refs PM-10294

libs/common/src/admin-console/models/domain/organization.ts

@@ -168,13 +168,8 @@ export class Organization {
     );
   }
 
-  canEditAnyCollection(flexibleCollectionsV1Enabled: boolean) {
-    if (!flexibleCollectionsV1Enabled) {
-      // Pre-Flexible Collections v1 logic
-      return this.isAdmin || this.permissions.editAnyCollection;
-    }
-
-    // Post Flexible Collections V1, the allowAdminAccessToAllCollectionItems flag can restrict admins
+  get canEditAnyCollection() {
+    // The allowAdminAccessToAllCollectionItems flag can restrict admins
     // Providers and custom users with canEditAnyCollection are not affected by allowAdminAccessToAllCollectionItems flag
     return (
       this.isProviderUser ||
@@ -183,7 +178,7 @@ export class Organization {
     );
   }
 
-  canEditUnmanagedCollections() {
+  get canEditUnmanagedCollections() {
     // Any admin or custom user with editAnyCollection permission can edit unmanaged collections
     return this.isAdmin || this.permissions.editAnyCollection;
   }
@@ -203,15 +198,7 @@ export class Organization {
     );
   }
 
-  canEditAllCiphers(
-    flexibleCollectionsV1Enabled: boolean,
-    restrictProviderAccessFlagEnabled: boolean,
-  ) {
-    // Before Flexible Collections V1, any admin or anyone with editAnyCollection permission could edit all ciphers
-    if (!flexibleCollectionsV1Enabled) {
-      return this.isAdmin || this.permissions.editAnyCollection;
-    }
-
+  canEditAllCiphers(restrictProviderAccessFlagEnabled: boolean) {
     // Providers can access items until the restrictProviderAccess flag is enabled
     // After the flag is enabled and removed, this block will be deleted
     // so that they permanently lose access to items
@@ -219,7 +206,7 @@ export class Organization {
       return true;
     }
 
-    // Post Flexible Collections V1, the allowAdminAccessToAllCollectionItems flag can restrict admins
+    // The allowAdminAccessToAllCollectionItems flag can restrict admins
     // Custom users with canEditAnyCollection are not affected by allowAdminAccessToAllCollectionItems flag
     return (
       (this.type === OrganizationUserType.Custom && this.permissions.editAnyCollection) ||
@@ -229,10 +216,9 @@ export class Organization {
   }
 
   /**
-   * @param flexibleCollectionsV1Enabled - Whether or not the V1 Flexible Collection feature flag is enabled
    * @returns True if the user can delete any collection
    */
-  canDeleteAnyCollection(flexibleCollectionsV1Enabled: boolean) {
+  get canDeleteAnyCollection() {
     // Providers and Users with DeleteAnyCollection permission can always delete collections
     if (this.isProviderUser || this.permissions.deleteAnyCollection) {
       return true;
@@ -240,7 +226,7 @@ export class Organization {
 
     // If AllowAdminAccessToAllCollectionItems is true, Owners and Admins can delete any collection, regardless of LimitCollectionCreationDeletion setting
     // Using explicit type checks because provider users are handled above and this mimics the server's permission checks closely
-    if (!flexibleCollectionsV1Enabled || this.allowAdminAccessToAllCollectionItems) {
+    if (this.allowAdminAccessToAllCollectionItems) {
       return this.type == OrganizationUserType.Owner || this.type == OrganizationUserType.Admin;
     }
 

libs/common/src/vault/models/view/collection.view.ts

@@ -38,11 +38,7 @@ export class CollectionView implements View, ITreeNodeObject {
     }
   }
 
-  canEditItems(
-    org: Organization,
-    v1FlexibleCollections: boolean,
-    restrictProviderAccess: boolean,
-  ): boolean {
+  canEditItems(org: Organization, restrictProviderAccess: boolean): boolean {
     if (org != null && org.id !== this.organizationId) {
       throw new Error(
         "Id of the organization provided does not match the org id of the collection.",
@@ -50,7 +46,7 @@ export class CollectionView implements View, ITreeNodeObject {
     }
 
     return (
-      org?.canEditAllCiphers(v1FlexibleCollections, restrictProviderAccess) ||
+      org?.canEditAllCiphers(restrictProviderAccess) ||
       this.manage ||
       (this.assigned && !this.readOnly)
     );
@@ -58,28 +54,23 @@ export class CollectionView implements View, ITreeNodeObject {
 
   /**
    * Returns true if the user can edit a collection (including user and group access) from the individual vault.
-   * After FCv1, does not include admin permissions - see {@link CollectionAdminView.canEdit}.
+   * Does not include admin permissions - see {@link CollectionAdminView.canEdit}.
    */
-  canEdit(org: Organization, flexibleCollectionsV1Enabled: boolean): boolean {
+  canEdit(org: Organization): boolean {
     if (org != null && org.id !== this.organizationId) {
       throw new Error(
         "Id of the organization provided does not match the org id of the collection.",
       );
     }
 
-    if (flexibleCollectionsV1Enabled) {
-      // Only use individual permissions, not admin permissions
-      return this.manage;
-    }
-
-    return org?.canEditAnyCollection(flexibleCollectionsV1Enabled) || this.manage;
+    return this.manage;
   }
 
   /**
    * Returns true if the user can delete a collection from the individual vault.
-   * After FCv1, does not include admin permissions - see {@link CollectionAdminView.canDelete}.
+   * Does not include admin permissions - see {@link CollectionAdminView.canDelete}.
    */
-  canDelete(org: Organization, flexibleCollectionsV1Enabled: boolean): boolean {
+  canDelete(org: Organization): boolean {
     if (org != null && org.id !== this.organizationId) {
       throw new Error(
         "Id of the organization provided does not match the org id of the collection.",
@@ -88,24 +79,14 @@ export class CollectionView implements View, ITreeNodeObject {
 
     const canDeleteManagedCollections = !org?.limitCollectionCreationDeletion || org.isAdmin;
 
-    if (flexibleCollectionsV1Enabled) {
-      // Only use individual permissions, not admin permissions
-      return canDeleteManagedCollections && this.manage;
-    }
-
-    return (
-      org?.canDeleteAnyCollection(flexibleCollectionsV1Enabled) ||
-      (canDeleteManagedCollections && this.manage)
-    );
+    // Only use individual permissions, not admin permissions
+    return canDeleteManagedCollections && this.manage;
   }
 
   /**
    * Returns true if the user can view collection info and access in a read-only state from the individual vault
    */
-  canViewCollectionInfo(
-    org: Organization | undefined,
-    flexibleCollectionsV1Enabled: boolean,
-  ): boolean {
+  canViewCollectionInfo(org: Organization | undefined): boolean {
     return false;
   }