From 47975fda37d5e68109de9485fe073f67a1bfe3c2 Mon Sep 17 00:00:00 2001 From: Daniel James Smith <2670567+djsmith85@users.noreply.github.com> Date: Mon, 27 Oct 2025 20:24:36 +0100 Subject: [PATCH] Address issues with eslint rules regarding signals and OnPush change detection (#17057) Co-authored-by: Daniel James Smith --- .../auto-confirm-edit-policy-dialog.component.ts | 16 ++++++++++------ .../auto-confirm-policy.component.ts | 6 ++++-- 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/apps/web/src/app/admin-console/organizations/policies/auto-confirm-edit-policy-dialog.component.ts b/apps/web/src/app/admin-console/organizations/policies/auto-confirm-edit-policy-dialog.component.ts index 18a9306b7d..55894aafd5 100644 --- a/apps/web/src/app/admin-console/organizations/policies/auto-confirm-edit-policy-dialog.component.ts +++ b/apps/web/src/app/admin-console/organizations/policies/auto-confirm-edit-policy-dialog.component.ts @@ -63,6 +63,8 @@ export type AutoConfirmPolicyDialogData = PolicyEditDialogData & { * Satisfies the PolicyDialogComponent interface structurally * via its static open() function. */ +// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush +// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection @Component({ templateUrl: "auto-confirm-edit-policy-dialog.component.html", imports: [SharedModule], @@ -73,8 +75,8 @@ export class AutoConfirmPolicyDialogComponent { policyType = PolicyType; - protected firstTimeDialog = signal(false); - protected currentStep = signal(0); + protected readonly firstTimeDialog = signal(false); + protected readonly currentStep = signal(0); protected multiStepSubmit: Observable = of([]); protected autoConfirmEnabled$: Observable = this.accountService.activeAccount$.pipe( getUserId, @@ -82,11 +84,13 @@ export class AutoConfirmPolicyDialogComponent map((policies) => policies.find((p) => p.type === PolicyType.AutoConfirm)?.enabled ?? false), ); - private submitPolicy: Signal | undefined> = viewChild("step0"); - private openExtension: Signal | undefined> = viewChild("step1"); + private readonly submitPolicy: Signal | undefined> = viewChild("step0"); + private readonly openExtension: Signal | undefined> = viewChild("step1"); - private submitPolicyTitle: Signal | undefined> = viewChild("step0Title"); - private openExtensionTitle: Signal | undefined> = viewChild("step1Title"); + private readonly submitPolicyTitle: Signal | undefined> = + viewChild("step0Title"); + private readonly openExtensionTitle: Signal | undefined> = + viewChild("step1Title"); override policyComponent: AutoConfirmPolicyEditComponent | undefined; diff --git a/apps/web/src/app/admin-console/organizations/policies/policy-edit-definitions/auto-confirm-policy.component.ts b/apps/web/src/app/admin-console/organizations/policies/policy-edit-definitions/auto-confirm-policy.component.ts index a5ea2ef879..7fa4fc2eea 100644 --- a/apps/web/src/app/admin-console/organizations/policies/policy-edit-definitions/auto-confirm-policy.component.ts +++ b/apps/web/src/app/admin-console/organizations/policies/policy-edit-definitions/auto-confirm-policy.component.ts @@ -26,14 +26,16 @@ export class AutoConfirmPolicy extends BasePolicyEditDefinition { } } +// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush +// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection @Component({ templateUrl: "auto-confirm-policy.component.html", imports: [SharedModule], }) export class AutoConfirmPolicyEditComponent extends BasePolicyEditComponent implements OnInit { protected readonly autoConfirmSvg = AutoConfirmSvg; - private policyForm: Signal | undefined> = viewChild("step0"); - private extensionButton: Signal | undefined> = viewChild("step1"); + private readonly policyForm: Signal | undefined> = viewChild("step0"); + private readonly extensionButton: Signal | undefined> = viewChild("step1"); protected step: number = 0; protected steps = [this.policyForm, this.extensionButton];