bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-20 02:03:39 +00:00
Code Issues Releases Wiki Activity

[EC-639] Replacing apostrophe char for email values in Policies API request (#4390)

Browse Source 
* [EC-639] Replacing single quote char for email values in Policies API request

* [EC-639] Added Utils.encodeRFC3986URIComponent and used in PolicyApiService and TwoFactorAuthenticatorComponent

* [EC-639] Added unit tests for Utils.encodeRFC3986URIComponent
This commit is contained in:
Rui Tomé
2023-01-25 14:00:46 +00:00
committed by GitHub
parent d40a891f71
commit 4a3bb4b241
4 changed files with 33 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
libs/common/src/misc/utils.ts
View File

@@ -486,6 +486,18 @@ export class Utils {
return Object.assign(destination, source) as unknown as Merge<Destination, Source>;
}
/**
* encodeURIComponent escapes all characters except the following:
* alphabetic, decimal digits, - _ . ! ~ * ' ( )
* https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent#encoding_for_rfc3986
*/
static encodeRFC3986URIComponent(str: string): string {
return encodeURIComponent(str).replace(
/[!'()*]/g,
(c) => `%${c.charCodeAt(0).toString(16).toUpperCase()}`
);
}
private static isMobile(win: Window) {
let mobile = false;
((a) => {

3
libs/common/src/services/policy/policy-api.service.ts
View File

@@ -5,6 +5,7 @@ import { PolicyApiServiceAbstraction } from "../../abstractions/policy/policy-ap
import { InternalPolicyService } from "../../abstractions/policy/policy.service.abstraction";
import { StateService } from "../../abstractions/state.service";
import { PolicyType } from "../../enums/policyType";
import { Utils } from "../../misc/utils";
import { PolicyData } from "../../models/data/policy.data";
import { MasterPasswordPolicyOptions } from "../../models/domain/master-password-policy-options";
import { PolicyRequest } from "../../models/request/policy.request";
@@ -54,7 +55,7 @@ export class PolicyApiService implements PolicyApiServiceAbstraction {
"token=" +
encodeURIComponent(token) +
"&email=" +
encodeURIComponent(email) +
Utils.encodeRFC3986URIComponent(email) +
"&organizationUserId=" +
organizationUserId,
null,