[PM-21794] - remove RemoveCardItemTypePolicy flag (#16450)

* remove restricted item types flag

* fix RestrictedItemTypesService constructor

apps/browser/src/background/main.background.ts

@@ -884,7 +884,6 @@ export default class MainBackground {
     );
 
     this.restrictedItemTypesService = new RestrictedItemTypesService(
-      this.configService,
       this.accountService,
       this.organizationService,
       this.policyService,

apps/cli/src/service-container/service-container.ts

@@ -689,7 +689,6 @@ export class ServiceContainer {
     );
 
     this.restrictedItemTypesService = new RestrictedItemTypesService(
-      this.configService,
       this.accountService,
       this.organizationService,
       this.policyService,

apps/web/src/app/admin-console/organizations/policies/policy-edit-definitions/restricted-item-types.component.ts

@@ -1,10 +1,6 @@
 import { Component } from "@angular/core";
-import { Observable } from "rxjs";
 
 import { PolicyType } from "@bitwarden/common/admin-console/enums";
-import { Organization } from "@bitwarden/common/admin-console/models/domain/organization";
-import { FeatureFlag } from "@bitwarden/common/enums/feature-flag.enum";
-import { ConfigService } from "@bitwarden/common/platform/abstractions/config/config.service";
 
 import { SharedModule } from "../../../../shared";
 import { BasePolicyEditDefinition, BasePolicyEditComponent } from "../base-policy-edit.component";
@@ -14,10 +10,6 @@ export class RestrictedItemTypesPolicy extends BasePolicyEditDefinition {
   description = "restrictedItemTypePolicyDesc";
   type = PolicyType.RestrictedItemTypes;
   component = RestrictedItemTypesPolicyComponent;
-
-  display$(organization: Organization, configService: ConfigService): Observable<boolean> {
-    return configService.getFeatureFlag$(FeatureFlag.RemoveCardItemTypePolicy);
-  }
 }
 
 @Component({

libs/angular/src/services/jslib-services.module.ts

@@ -692,7 +692,7 @@ const safeProviders: SafeProvider[] = [
   safeProvider({
     provide: RestrictedItemTypesService,
     useClass: RestrictedItemTypesService,
-    deps: [ConfigService, AccountService, OrganizationServiceAbstraction, PolicyServiceAbstraction],
+    deps: [AccountService, OrganizationServiceAbstraction, PolicyServiceAbstraction],
   }),
   safeProvider({
     provide: PasswordStrengthServiceAbstraction,

libs/common/src/enums/feature-flag.enum.ts

@@ -48,7 +48,6 @@ export enum FeatureFlag {
   PM22134SdkCipherListView = "pm-22134-sdk-cipher-list-view",
   PM22136_SdkCipherEncryption = "pm-22136-sdk-cipher-encryption",
   CipherKeyEncryption = "cipher-key-encryption",
-  RemoveCardItemTypePolicy = "pm-16442-remove-card-item-type-policy",
 
   /* Platform */
   IpcChannelFramework = "ipc-channel-framework",
@@ -90,7 +89,6 @@ export const DefaultFeatureFlagValue = {
   /* Vault */
   [FeatureFlag.CipherKeyEncryption]: FALSE,
   [FeatureFlag.PM19941MigrateCipherDomainToSdk]: FALSE,
-  [FeatureFlag.RemoveCardItemTypePolicy]: FALSE,
   [FeatureFlag.PM22134SdkCipherListView]: FALSE,
   [FeatureFlag.PM22136_SdkCipherEncryption]: FALSE,
 

libs/common/src/vault/services/restricted-item-types.service.spec.ts

@@ -52,12 +52,7 @@ describe("RestrictedItemTypesService", () => {
     organizationService.organizations$.mockReturnValue(of([org1, org2]));
     policyService.policiesByType$.mockReturnValue(of([]));
 
-    service = new RestrictedItemTypesService(
-      configService,
-      accountService,
-      organizationService,
-      policyService,
-    );
+    service = new RestrictedItemTypesService(accountService, organizationService, policyService);
   });
 
   it("emits empty array when feature flag is disabled", async () => {

libs/common/src/vault/services/restricted-item-types.service.ts

@@ -6,8 +6,6 @@ import { PolicyService } from "@bitwarden/common/admin-console/abstractions/poli
 import { PolicyType } from "@bitwarden/common/admin-console/enums";
 import { AccountService } from "@bitwarden/common/auth/abstractions/account.service";
 import { getOptionalUserId } from "@bitwarden/common/auth/services/account.service";
-import { FeatureFlag } from "@bitwarden/common/enums/feature-flag.enum";
-import { ConfigService } from "@bitwarden/common/platform/abstractions/config/config.service";
 import { CipherType } from "@bitwarden/common/vault/enums";
 
 import { uuidAsString } from "../../platform/abstractions/sdk/sdk.service";
@@ -25,14 +23,8 @@ export class RestrictedItemTypesService {
    * - cipherType: each type restricted by at least one org-level policy
    * - allowViewOrgIds: org IDs that allow viewing that type
    */
-  readonly restricted$: Observable<RestrictedCipherType[]> = this.configService
-    .getFeatureFlag$(FeatureFlag.RemoveCardItemTypePolicy)
-    .pipe(
-      switchMap((flagOn) => {
-        if (!flagOn) {
-          return of([]);
-        }
-        return this.accountService.activeAccount$.pipe(
+  readonly restricted$: Observable<RestrictedCipherType[]> =
+    this.accountService.activeAccount$.pipe(
       getOptionalUserId,
       switchMap((userId) => {
         if (userId == null) {
@@ -71,14 +63,11 @@ export class RestrictedItemTypesService {
           }),
         );
       }),
-        );
-      }),
       distinctUntilChanged(),
       shareReplay({ bufferSize: 1, refCount: true }),
     );
 
   constructor(
-    private configService: ConfigService,
     private accountService: AccountService,
     private organizationService: OrganizationService,
     private policyService: PolicyService,