mirror of
https://github.com/bitwarden/browser
synced 2025-12-19 01:33:33 +00:00
[PM-3756] Disable node integration and enable context isolation in desktop (#6975)
* Disable node integration and enable context isolation * Review comments * Log in renderer through IPC * Missed imports * Mock electron API * resourcesPath is undefined in the preload, but process.windowsStore works correctly * Replace fromBufferToUtf8 conditional implementation for the `buffer` package The current non-node implementation is different than the node implementation, as the non-node would break when the contents can't be parsed as a URI component. Replacing the impl by the `buffer` package makes the result match in both environments. * Fix lint * Add some more tests * Remove buffer from devDependencies
This commit is contained in:
@@ -160,11 +160,11 @@ export class WindowMain {
|
||||
backgroundColor: await this.getBackgroundColor(),
|
||||
alwaysOnTop: this.enableAlwaysOnTop,
|
||||
webPreferences: {
|
||||
// preload: path.join(__dirname, "preload.js"),
|
||||
preload: path.join(__dirname, "preload.js"),
|
||||
spellcheck: false,
|
||||
nodeIntegration: true,
|
||||
nodeIntegration: false,
|
||||
backgroundThrottling: false,
|
||||
contextIsolation: false,
|
||||
contextIsolation: true,
|
||||
session: this.session,
|
||||
},
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user