mirror of
https://github.com/bitwarden/browser
synced 2025-12-12 14:23:32 +00:00
[PM-3756] Disable node integration and enable context isolation in desktop (#6975)
* Disable node integration and enable context isolation * Review comments * Log in renderer through IPC * Missed imports * Mock electron API * resourcesPath is undefined in the preload, but process.windowsStore works correctly * Replace fromBufferToUtf8 conditional implementation for the `buffer` package The current non-node implementation is different than the node implementation, as the non-node would break when the contents can't be parsed as a URI component. Replacing the impl by the `buffer` package makes the result match in both environments. * Fix lint * Add some more tests * Remove buffer from devDependencies
This commit is contained in:
@@ -54,6 +54,10 @@ const common = {
|
||||
extensions: [".tsx", ".ts", ".js"],
|
||||
symlinks: false,
|
||||
modules: [path.resolve("../../node_modules")],
|
||||
fallback: {
|
||||
path: require.resolve("path-browserify"),
|
||||
fs: false,
|
||||
},
|
||||
},
|
||||
output: {
|
||||
filename: "[name].js",
|
||||
@@ -64,9 +68,7 @@ const common = {
|
||||
const renderer = {
|
||||
mode: NODE_ENV,
|
||||
devtool: "source-map",
|
||||
// TODO: Replace this with web.
|
||||
// target: "web",
|
||||
target: "electron-renderer",
|
||||
target: "web",
|
||||
node: {
|
||||
__dirname: false,
|
||||
},
|
||||
|
||||
Reference in New Issue
Block a user