From 4cd8d4e61df4f2ca166896a599b6997a2be8cb52 Mon Sep 17 00:00:00 2001 From: Cesar Gonzalez Date: Tue, 25 Jun 2024 04:22:15 -0500 Subject: [PATCH] [PM-5189] Fixing issues found within code review behind how we position elements --- .../src/autofill/background/overlay.background.ts | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/apps/browser/src/autofill/background/overlay.background.ts b/apps/browser/src/autofill/background/overlay.background.ts index 7cdd8fb3776..3469dd67161 100644 --- a/apps/browser/src/autofill/background/overlay.background.ts +++ b/apps/browser/src/autofill/background/overlay.background.ts @@ -1097,11 +1097,21 @@ export class OverlayBackground implements OverlayBackgroundInterface { private async checkIsInlineMenuButtonVisible( sender: chrome.runtime.MessageSender, ): Promise { - return await BrowserApi.tabSendMessage( + const isVisible = !!(await BrowserApi.tabSendMessage( sender.tab, { command: "checkIsAutofillInlineMenuButtonVisible" }, { frameId: 0 }, - ); + )); + + // If the element is visible in the DOM, ensure that it is not hidden by CSS. + if (isVisible) { + void this.toggleInlineMenuHidden( + { isInlineMenuHidden: false, setTransparentInlineMenu: false }, + sender, + ); + } + + return isVisible; } /**