bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-11 05:43:41 +00:00
Code Issues Releases Wiki Activity

remove inlineAutofillMenuRefreshAddEditCipher message (#13805)

Browse Source
This commit is contained in:
Jonathan Prusik
2025-04-15 14:39:48 -04:00
committed by GitHub
parent e3d1ef456e
commit 4cddc40828
4 changed files with 0 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
apps/browser/src/autofill/background/overlay.background.spec.ts
View File

@@ -117,7 +117,6 @@ describe("OverlayBackground", () => {
let getFrameDetailsSpy: jest.SpyInstance; let getFrameDetailsSpy: jest.SpyInstance;
let tabsSendMessageSpy: jest.SpyInstance; let tabsSendMessageSpy: jest.SpyInstance;
let tabSendMessageDataSpy: jest.SpyInstance; let tabSendMessageDataSpy: jest.SpyInstance;
let sendMessageSpy: jest.SpyInstance;
let getTabFromCurrentWindowIdSpy: jest.SpyInstance; let getTabFromCurrentWindowIdSpy: jest.SpyInstance;
let getTabSpy: jest.SpyInstance; let getTabSpy: jest.SpyInstance;
let openUnlockPopoutSpy: jest.SpyInstance; let openUnlockPopoutSpy: jest.SpyInstance;
@@ -228,7 +227,6 @@ describe("OverlayBackground", () => {
tabSendMessageDataSpy = jest tabSendMessageDataSpy = jest
.spyOn(BrowserApi, "tabSendMessageData") .spyOn(BrowserApi, "tabSendMessageData")
.mockImplementation(() => Promise.resolve()); .mockImplementation(() => Promise.resolve());
sendMessageSpy = jest.spyOn(BrowserApi, "sendMessage");
getTabFromCurrentWindowIdSpy = jest.spyOn(BrowserApi, "getTabFromCurrentWindowId"); getTabFromCurrentWindowIdSpy = jest.spyOn(BrowserApi, "getTabFromCurrentWindowId");
getTabSpy = jest.spyOn(BrowserApi, "getTab"); getTabSpy = jest.spyOn(BrowserApi, "getTab");
openUnlockPopoutSpy = jest.spyOn(overlayBackground as any, "openUnlockPopout"); openUnlockPopoutSpy = jest.spyOn(overlayBackground as any, "openUnlockPopout");
@@ -1553,7 +1551,6 @@ describe("OverlayBackground", () => {
await flushPromises(); await flushPromises();
expect(cipherService.setAddEditCipherInfo).toHaveBeenCalled(); expect(cipherService.setAddEditCipherInfo).toHaveBeenCalled();
expect(sendMessageSpy).toHaveBeenCalledWith("inlineAutofillMenuRefreshAddEditCipher");
expect(openAddEditVaultItemPopoutSpy).toHaveBeenCalled(); expect(openAddEditVaultItemPopoutSpy).toHaveBeenCalled();
}); });
@@ -1579,7 +1576,6 @@ describe("OverlayBackground", () => {
await flushPromises(); await flushPromises();
expect(cipherService.setAddEditCipherInfo).toHaveBeenCalled(); expect(cipherService.setAddEditCipherInfo).toHaveBeenCalled();
expect(sendMessageSpy).toHaveBeenCalledWith("inlineAutofillMenuRefreshAddEditCipher");
expect(openAddEditVaultItemPopoutSpy).toHaveBeenCalled(); expect(openAddEditVaultItemPopoutSpy).toHaveBeenCalled();
}); });
@@ -1618,7 +1614,6 @@ describe("OverlayBackground", () => {
await flushPromises(); await flushPromises();
expect(cipherService.setAddEditCipherInfo).toHaveBeenCalled(); expect(cipherService.setAddEditCipherInfo).toHaveBeenCalled();
expect(sendMessageSpy).toHaveBeenCalledWith("inlineAutofillMenuRefreshAddEditCipher");
expect(openAddEditVaultItemPopoutSpy).toHaveBeenCalled(); expect(openAddEditVaultItemPopoutSpy).toHaveBeenCalled();
}); });

1
apps/browser/src/autofill/background/overlay.background.ts
View File

@@ -2434,7 +2434,6 @@ export class OverlayBackground implements OverlayBackgroundInterface {
cipherId: cipherView.id, cipherId: cipherView.id,
cipherType: addNewCipherType, cipherType: addNewCipherType,
}); });
await BrowserApi.sendMessage("inlineAutofillMenuRefreshAddEditCipher");
} catch (error) { } catch (error) {
this.logService.error("Error building cipher and opening add/edit vault item popout", error); this.logService.error("Error building cipher and opening add/edit vault item popout", error);
} }

3
apps/browser/src/autofill/deprecated/background/overlay.background.deprecated.spec.ts
View File

@@ -647,9 +647,6 @@ describe("OverlayBackground", () => {
await flushPromises(); await flushPromises();
expect(overlayBackground["cipherService"].setAddEditCipherInfo).toHaveBeenCalled(); expect(overlayBackground["cipherService"].setAddEditCipherInfo).toHaveBeenCalled();
expect(BrowserApi.sendMessage).toHaveBeenCalledWith(
"inlineAutofillMenuRefreshAddEditCipher",
);
expect(overlayBackground["openAddEditVaultItemPopout"]).toHaveBeenCalled(); expect(overlayBackground["openAddEditVaultItemPopout"]).toHaveBeenCalled();
}); });
}); });

1
apps/browser/src/autofill/deprecated/background/overlay.background.deprecated.ts
View File

@@ -678,7 +678,6 @@ class LegacyOverlayBackground implements OverlayBackgroundInterface {
); );
await this.openAddEditVaultItemPopout(sender.tab, { cipherId: cipherView.id }); await this.openAddEditVaultItemPopout(sender.tab, { cipherId: cipherView.id });
await BrowserApi.sendMessage("inlineAutofillMenuRefreshAddEditCipher");
} }
/** /**