Removing critical applications feature flag and logic (#14889)

bitwarden_license/bit-web/src/app/dirt/access-intelligence/all-applications.component.html

@@ -59,7 +59,6 @@
       type="button"
       [buttonType]="'primary'"
       bitButton
-      *ngIf="isCriticalAppsFeatureEnabled"
       [disabled]="!selectedUrls.size"
       [loading]="markingAsCritical"
       (click)="markAppsAsCritical()"
@@ -74,7 +73,6 @@
     [showRowCheckBox]="true"
     [showRowMenuForCriticalApps]="false"
     [selectedUrls]="selectedUrls"
-    [isCriticalAppsFeatureEnabled]="isCriticalAppsFeatureEnabled"
     [isDrawerIsOpenForThisRecord]="isDrawerOpenForTableRow"
     [checkboxChange]="onCheckboxChange"
     [showAppAtRiskMembers]="showAppAtRiskMembers"

bitwarden_license/bit-web/src/app/dirt/access-intelligence/all-applications.component.ts

@@ -21,7 +21,6 @@ import {
 import { Organization } from "@bitwarden/common/admin-console/models/domain/organization";
 import { AccountService } from "@bitwarden/common/auth/abstractions/account.service";
 import { getUserId } from "@bitwarden/common/auth/services/account.service";
-import { FeatureFlag } from "@bitwarden/common/enums/feature-flag.enum";
 import { ConfigService } from "@bitwarden/common/platform/abstractions/config/config.service";
 import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service";
 import { CipherService } from "@bitwarden/common/vault/abstractions/cipher.service";
@@ -74,13 +73,8 @@ export class AllApplicationsComponent implements OnInit {
 
   destroyRef = inject(DestroyRef);
   isLoading$: Observable<boolean> = of(false);
-  isCriticalAppsFeatureEnabled = false;
 
   async ngOnInit() {
-    this.isCriticalAppsFeatureEnabled = await this.configService.getFeatureFlag(
-      FeatureFlag.CriticalApps,
-    );
-
     const organizationId = this.activatedRoute.snapshot.paramMap.get("organizationId") ?? "";
     const userId = await firstValueFrom(getUserId(this.accountService.activeAccount$));
 

bitwarden_license/bit-web/src/app/dirt/access-intelligence/app-table-row-scrollable.component.html

@@ -1,7 +1,7 @@
 <ng-container>
   <bit-table-scroll [dataSource]="dataSource" [rowSize]="53">
     <ng-container header>
-      <th *ngIf="isCriticalAppsFeatureEnabled"></th>
+      <th></th>
       <th bitCell></th>
       <th bitSortable="applicationName" bitCell>{{ "application" | i18n }}</th>
       <th bitSortable="atRiskPasswordCount" bitCell>{{ "atRiskPasswords" | i18n }}</th>
@@ -12,7 +12,7 @@
     <ng-template bitRowDef let-row>
       <td
         bitCell
-        *ngIf="isCriticalAppsFeatureEnabled && showRowCheckBox"
+        *ngIf="showRowCheckBox"
         [ngClass]="{ 'tw-bg-primary-100': isDrawerIsOpenForThisRecord(row.applicationName) }"
       >
         <input

bitwarden_license/bit-web/src/app/dirt/access-intelligence/app-table-row-scrollable.component.ts

@@ -18,7 +18,6 @@ export class AppTableRowScrollableComponent {
   @Input() showRowMenuForCriticalApps: boolean = false;
   @Input() showRowCheckBox: boolean = false;
   @Input() selectedUrls: Set<string> = new Set<string>();
-  @Input() isCriticalAppsFeatureEnabled: boolean = false;
   @Input() isDrawerIsOpenForThisRecord!: (applicationName: string) => boolean;
   @Input() showAppAtRiskMembers!: (applicationName: string) => void;
   @Input() unmarkAsCriticalApp!: (applicationName: string) => void;

bitwarden_license/bit-web/src/app/dirt/access-intelligence/critical-applications.component.html

@@ -82,7 +82,6 @@
     [dataSource]="dataSource"
     [showRowCheckBox]="false"
     [showRowMenuForCriticalApps]="true"
-    [isCriticalAppsFeatureEnabled]="true"
     [isDrawerIsOpenForThisRecord]="isDrawerOpenForTableRow"
     [showAppAtRiskMembers]="showAppAtRiskMembers"
     [unmarkAsCriticalApp]="unmarkAsCriticalApp"

bitwarden_license/bit-web/src/app/dirt/access-intelligence/risk-insights.component.html

@@ -38,7 +38,7 @@
       <bit-tab label="{{ 'allApplicationsWithCount' | i18n: appsCount }}">
         <tools-all-applications></tools-all-applications>
       </bit-tab>
-      <bit-tab *ngIf="isCriticalAppsFeatureEnabled">
+      <bit-tab>
         <ng-template bitTabLabel>
           <i class="bwi bwi-star"></i>
           {{ "criticalApplicationsWithCount" | i18n: (criticalApps$ | async)?.length ?? 0 }}

bitwarden_license/bit-web/src/app/dirt/access-intelligence/risk-insights.component.ts

@@ -15,7 +15,6 @@ import {
   DrawerType,
   PasswordHealthReportApplicationsResponse,
 } from "@bitwarden/bit-common/dirt/reports/risk-insights/models/password-health";
-import { FeatureFlag } from "@bitwarden/common/enums/feature-flag.enum";
 import { ConfigService } from "@bitwarden/common/platform/abstractions/config/config.service";
 import { devFlagEnabled } from "@bitwarden/common/platform/misc/flags";
 import { OrganizationId } from "@bitwarden/common/types/guid";
@@ -70,7 +69,6 @@ export class RiskInsightsComponent implements OnInit {
 
   dataLastUpdated: Date = new Date();
 
-  isCriticalAppsFeatureEnabled: boolean = false;
   criticalApps$: Observable<PasswordHealthReportApplicationsResponse[]> = new Observable();
   showDebugTabs: boolean = false;
 
@@ -100,10 +98,6 @@ export class RiskInsightsComponent implements OnInit {
   }
 
   async ngOnInit() {
-    this.isCriticalAppsFeatureEnabled = await this.configService.getFeatureFlag(
-      FeatureFlag.CriticalApps,
-    );
-
     this.showDebugTabs = devFlagEnabled("showRiskInsightsDebug");
 
     this.route.paramMap

libs/common/src/enums/feature-flag.enum.ts

@@ -36,7 +36,6 @@ export enum FeatureFlag {
   UseOrganizationWarningsService = "use-organization-warnings-service",
 
   /* Data Insights and Reporting */
-  CriticalApps = "pm-14466-risk-insights-critical-application",
   EnableRiskInsightsNotifications = "enable-risk-insights-notifications",
 
   /* Key Management */
@@ -93,7 +92,6 @@ export const DefaultFeatureFlagValue = {
   [FeatureFlag.MacOsNativeCredentialSync]: FALSE,
 
   /* Data Insights and Reporting */
-  [FeatureFlag.CriticalApps]: FALSE,
   [FeatureFlag.EnableRiskInsightsNotifications]: FALSE,
 
   /* Tools */