fix(ci): Resolve errors and warnings exposed by new workflow linter (#12755)

* fix(ci): Resolve errors and warnings exposed by new workflow linter

* Add missed warning

.github/workflows/deploy-web.yml

@@ -63,14 +63,14 @@ jobs:
     runs-on: ubuntu-22.04
     outputs:
       environment: ${{ steps.config.outputs.environment }}
-      environment-url: ${{ steps.config.outputs.environment-url }}
-      environment-name: ${{ steps.config.outputs.environment-name }}
-      environment-artifact: ${{ steps.config.outputs.environment-artifact }}
-      azure-login-creds: ${{ steps.config.outputs.azure-login-creds }}
-      retrieve-secrets-keyvault: ${{ steps.config.outputs.retrieve-secrets-keyvault }}
-      sync-utility: ${{ steps.config.outputs.sync-utility }}
-      sync-delete-destination-files: ${{ steps.config.outputs.sync-delete-destination-files }}
-      slack-channel-name: ${{ steps.config.outputs.slack-channel-name }}
+      environment_url: ${{ steps.config.outputs.environment_url }}
+      environment_name: ${{ steps.config.outputs.environment_name }}
+      environment_artifact: ${{ steps.config.outputs.environment_artifact }}
+      azure_login_creds: ${{ steps.config.outputs.azure_login_creds }}
+      retrive_secrets_keyvault: ${{ steps.config.outputs.retrive_secrets_keyvault }}
+      sync_utility: ${{ steps.config.outputs.sync_utility }}
+      sync_delete_destination_files: ${{ steps.config.outputs.sync_delete_destination_files }}
+      slack_channel_name: ${{ steps.config.outputs.slack-channel-name }}
     steps:
       - name: Configure
         id: config
@@ -81,48 +81,48 @@ jobs:
 
           case ${{ inputs.environment }} in
             "USQA")
-              echo "azure-login-creds=AZURE_KV_US_QA_SERVICE_PRINCIPAL" >> $GITHUB_OUTPUT
-              echo "retrieve-secrets-keyvault=bw-webvault-rlktusqa-kv" >> $GITHUB_OUTPUT
-              echo "environment-artifact=web-*-cloud-QA.zip" >> $GITHUB_OUTPUT
-              echo "environment-name=Web Vault - US QA Cloud" >> $GITHUB_OUTPUT
-              echo "environment-url=http://vault.$ENV_NAME_LOWER.bitwarden.pw" >> $GITHUB_OUTPUT
-              echo "slack-channel-name=alerts-deploy-qa"  >> $GITHUB_OUTPUT
+              echo "azure_login_creds=AZURE_KV_US_QA_SERVICE_PRINCIPAL" >> $GITHUB_OUTPUT
+              echo "retrive_secrets_keyvault=bw-webvault-rlktusqa-kv" >> $GITHUB_OUTPUT
+              echo "environment_artifact=web-*-cloud-QA.zip" >> $GITHUB_OUTPUT
+              echo "environment_name=Web Vault - US QA Cloud" >> $GITHUB_OUTPUT
+              echo "environment_url=http://vault.$ENV_NAME_LOWER.bitwarden.pw" >> $GITHUB_OUTPUT
+              echo "slack_channel_name=alerts-deploy-qa"  >> $GITHUB_OUTPUT
               ;;
             "EUQA")
-              echo "azure-login-creds=AZURE_KV_EU_QA_SERVICE_PRINCIPAL" >> $GITHUB_OUTPUT
-              echo "retrieve-secrets-keyvault=webvaulteu-westeurope-qa" >> $GITHUB_OUTPUT
-              echo "environment-artifact=web-*-cloud-euqa.zip" >> $GITHUB_OUTPUT
-              echo "environment-name=Web Vault - EU QA Cloud" >> $GITHUB_OUTPUT
-              echo "environment-url=http://vault.$ENV_NAME_LOWER.bitwarden.pw" >> $GITHUB_OUTPUT
-              echo "slack-channel-name=alerts-deploy-qa"  >> $GITHUB_OUTPUT
+              echo "azure_login_creds=AZURE_KV_EU_QA_SERVICE_PRINCIPAL" >> $GITHUB_OUTPUT
+              echo "retrive_secrets_keyvault=webvaulteu-westeurope-qa" >> $GITHUB_OUTPUT
+              echo "environment_artifact=web-*-cloud-euqa.zip" >> $GITHUB_OUTPUT
+              echo "environment_name=Web Vault - EU QA Cloud" >> $GITHUB_OUTPUT
+              echo "environment_url=http://vault.$ENV_NAME_LOWER.bitwarden.pw" >> $GITHUB_OUTPUT
+              echo "slack_channel_name=alerts-deploy-qa"  >> $GITHUB_OUTPUT
               ;;
             "USPROD")
-              echo "azure-login-creds=AZURE_KV_US_PROD_SERVICE_PRINCIPAL" >> $GITHUB_OUTPUT
-              echo "retrieve-secrets-keyvault=bw-webvault-klrt-kv" >> $GITHUB_OUTPUT
-              echo "environment-artifact=web-*-cloud-COMMERCIAL.zip" >> $GITHUB_OUTPUT
-              echo "environment-name=Web Vault - US Production Cloud" >> $GITHUB_OUTPUT
-              echo "environment-url=http://vault.bitwarden.com" >> $GITHUB_OUTPUT
-              echo "slack-channel-name=alerts-deploy-prd"  >> $GITHUB_OUTPUT
+              echo "azure_login_creds=AZURE_KV_US_PROD_SERVICE_PRINCIPAL" >> $GITHUB_OUTPUT
+              echo "retrive_secrets_keyvault=bw-webvault-klrt-kv" >> $GITHUB_OUTPUT
+              echo "environment_artifact=web-*-cloud-COMMERCIAL.zip" >> $GITHUB_OUTPUT
+              echo "environment_name=Web Vault - US Production Cloud" >> $GITHUB_OUTPUT
+              echo "environment_url=http://vault.bitwarden.com" >> $GITHUB_OUTPUT
+              echo "slack_channel_name=alerts-deploy-prd"  >> $GITHUB_OUTPUT
               ;;
             "EUPROD")
-              echo "azure-login-creds=AZURE_KV_EU_PRD_SERVICE_PRINCIPAL" >> $GITHUB_OUTPUT
-              echo "retrieve-secrets-keyvault=webvault-westeurope-prod" >> $GITHUB_OUTPUT
-              echo "environment-artifact=web-*-cloud-euprd.zip" >> $GITHUB_OUTPUT
-              echo "environment-name=Web Vault - EU Production Cloud" >> $GITHUB_OUTPUT
-              echo "environment-url=http://vault.bitwarden.eu" >> $GITHUB_OUTPUT
-              echo "slack-channel-name=alerts-deploy-prd"  >> $GITHUB_OUTPUT
+              echo "azure_login_creds=AZURE_KV_EU_PRD_SERVICE_PRINCIPAL" >> $GITHUB_OUTPUT
+              echo "retrive_secrets_keyvault=webvault-westeurope-prod" >> $GITHUB_OUTPUT
+              echo "environment_artifact=web-*-cloud-euprd.zip" >> $GITHUB_OUTPUT
+              echo "environment_name=Web Vault - EU Production Cloud" >> $GITHUB_OUTPUT
+              echo "environment_url=http://vault.bitwarden.eu" >> $GITHUB_OUTPUT
+              echo "slack_channel_name=alerts-deploy-prd"  >> $GITHUB_OUTPUT
               ;;
             "USDEV")
-              echo "azure-login-creds=AZURE_KV_US_DEV_SERVICE_PRINCIPAL" >> $GITHUB_OUTPUT
-              echo "retrieve-secrets-keyvault=webvault-eastus-dev" >> $GITHUB_OUTPUT
-              echo "environment-artifact=web-*-cloud-usdev.zip" >> $GITHUB_OUTPUT
-              echo "environment-name=Web Vault - US Development Cloud" >> $GITHUB_OUTPUT
-              echo "environment-url=http://vault.$ENV_NAME_LOWER.bitwarden.pw" >> $GITHUB_OUTPUT
-              echo "slack-channel-name=alerts-deploy-dev"  >> $GITHUB_OUTPUT
+              echo "azure_login_creds=AZURE_KV_US_DEV_SERVICE_PRINCIPAL" >> $GITHUB_OUTPUT
+              echo "retrive_secrets_keyvault=webvault-eastus-dev" >> $GITHUB_OUTPUT
+              echo "environment_artifact=web-*-cloud-usdev.zip" >> $GITHUB_OUTPUT
+              echo "environment_name=Web Vault - US Development Cloud" >> $GITHUB_OUTPUT
+              echo "environment_url=http://vault.$ENV_NAME_LOWER.bitwarden.pw" >> $GITHUB_OUTPUT
+              echo "slack_channel_name=alerts-deploy-dev"  >> $GITHUB_OUTPUT
               ;;
           esac
           # Set the sync utility to use for deployment to the environment (az-sync or azcopy)
-          echo "sync-utility=azcopy" >> $GITHUB_OUTPUT
+          echo "sync_utility=azcopy" >> $GITHUB_OUTPUT
 
       - name: Environment Protection
         env:
@@ -168,10 +168,10 @@ jobs:
           fi
 
   approval:
-    name: Approval for Deployment to ${{ needs.setup.outputs.environment-name }}
+    name: Approval for Deployment to ${{ needs.setup.outputs.environment_name }}
     needs: setup
     runs-on: ubuntu-22.04
-    environment: ${{ needs.setup.outputs.environment-name }}
+    environment: ${{ needs.setup.outputs.environment_name }}
     steps:
       - name: Success Code
         run: exit 0
@@ -181,9 +181,9 @@ jobs:
     runs-on: ubuntu-22.04
     needs: setup
     env:
-      _ENVIRONMENT_ARTIFACT: ${{ needs.setup.outputs.environment-artifact }}
+      _ENVIRONMENT_ARTIFACT: ${{ needs.setup.outputs.environment_artifact }}
     outputs:
-      artifact-build-commit: ${{ steps.set-artifact-commit.outputs.commit }}
+      artifact_build_commit: ${{ steps.set-artifact-commit.outputs.commit }}
     steps:
       - name: 'Download latest cloud asset using GitHub Run ID: ${{ inputs.build-web-run-id }}'
         if: ${{ inputs.build-web-run-id }}
@@ -242,7 +242,7 @@ jobs:
         run: |
           # If run-id was used, get the commit from the download-latest-artifacts-run-id step
           if [ "${{ inputs.build-web-run-id }}" ]; then
-            echo "commit=${{ steps.download-latest-artifacts-run-id.outputs.artifact-build-commit }}" >> $GITHUB_OUTPUT
+            echo "commit=${{ steps.download-latest-artifacts-run-id.outputs.artifact_build_commit }}" >> $GITHUB_OUTPUT
 
           elif [ "${{ steps.download-latest-artifacts.outcome }}" == "failure" ]; then
             # If the download-latest-artifacts step failed, query the GH API to get the commit SHA of the artifact that was just built with trigger-build-web.
@@ -251,7 +251,7 @@ jobs:
 
           else
             # Set the commit to the output of step download-latest-artifacts.
-            echo "commit=${{ steps.download-latest-artifacts.outputs.artifact-build-commit }}" >> $GITHUB_OUTPUT
+            echo "commit=${{ steps.download-latest-artifacts.outputs.artifact_build_commit }}" >> $GITHUB_OUTPUT
           fi
 
   notify-start:
@@ -271,11 +271,11 @@ jobs:
         id: slack-message
         with:
           project: Clients
-          environment: ${{ needs.setup.outputs.environment-name }}
+          environment: ${{ needs.setup.outputs.environment_name }}
           tag: ${{ inputs.branch-or-tag }}
-          slack-channel: ${{ needs.setup.outputs.slack-channel-name }}
+          slack-channel: ${{ needs.setup.outputs.slack_channel_name }}
           event: 'start'
-          commit-sha: ${{ needs.artifact-check.outputs.artifact-build-commit }}
+          commit-sha: ${{ needs.artifact-check.outputs.artifact_build_commit }}
           url: https://github.com/bitwarden/clients/actions/runs/${{ github.run_id }}
           AZURE_KV_CI_SERVICE_PRINCIPAL: ${{ secrets.AZURE_KV_CI_SERVICE_PRINCIPAL }}
 
@@ -287,7 +287,7 @@ jobs:
       - name: Display commit SHA
         run: |
           REPO_URL="https://github.com/bitwarden/clients/commit"
-          COMMIT_SHA="${{ needs.artifact-check.outputs.artifact-build-commit }}"
+          COMMIT_SHA="${{ needs.artifact-check.outputs.artifact_build_commit }}"
           echo ":steam_locomotive: View [commit]($REPO_URL/$COMMIT_SHA)" >> $GITHUB_STEP_SUMMARY
 
   azure-deploy:
@@ -299,9 +299,9 @@ jobs:
     runs-on: ubuntu-22.04
     env:
       _ENVIRONMENT: ${{ needs.setup.outputs.environment }}
-      _ENVIRONMENT_URL: ${{ needs.setup.outputs.environment-url }}
-      _ENVIRONMENT_NAME: ${{ needs.setup.outputs.environment-name }}
-      _ENVIRONMENT_ARTIFACT: ${{ needs.setup.outputs.environment-artifact }}
+      _ENVIRONMENT_URL: ${{ needs.setup.outputs.environment_url }}
+      _ENVIRONMENT_NAME: ${{ needs.setup.outputs.environment_name }}
+      _ENVIRONMENT_ARTIFACT: ${{ needs.setup.outputs.environment_artifact }}
     steps:
       - name: Create GitHub deployment
         uses: chrnorm/deployment-action@55729fcebec3d284f60f5bcabbd8376437d696b1 # v2.0.7
@@ -309,31 +309,31 @@ jobs:
         with:
           token: '${{ secrets.GITHUB_TOKEN }}'
           initial-status: 'in_progress'
-          environment-url: ${{ env._ENVIRONMENT_URL }}
+          environment_url: ${{ env._ENVIRONMENT_URL }}
           environment: ${{ env._ENVIRONMENT_NAME }}
           task: 'deploy'
           description: 'Deployment from branch/tag: ${{ inputs.branch-or-tag }}'
-          ref: ${{ needs.artifact-check.outputs.artifact-build-commit }}
+          ref: ${{ needs.artifact-check.outputs.artifact_build_commit }}
 
       - name: Login to Azure
         uses: Azure/login@e15b166166a8746d1a47596803bd8c1b595455cf # v1.6.0
         with:
-          creds: ${{ secrets[needs.setup.outputs.azure-login-creds] }}
+          creds: ${{ secrets[needs.setup.outputs.azure_login_creds] }}
 
       - name: Retrieve Storage Account connection string for az sync
-        if: ${{ needs.setup.outputs.sync-utility == 'az-sync' }}
+        if: ${{ needs.setup.outputs.sync_utility == 'az-sync' }}
         id: retrieve-secrets-az-sync
         uses: bitwarden/gh-actions/get-keyvault-secrets@main
         with:
-          keyvault: ${{ needs.setup.outputs.retrieve-secrets-keyvault }}
+          keyvault: ${{ needs.setup.outputs.retrive_secrets_keyvault }}
           secrets: "sa-bitwarden-web-vault-dev-key-temp"
 
       - name: Retrieve Storage Account name and SPN credentials for azcopy
-        if: ${{ needs.setup.outputs.sync-utility == 'azcopy' }}
+        if: ${{ needs.setup.outputs.sync_utility == 'azcopy' }}
         id: retrieve-secrets-azcopy
         uses: bitwarden/gh-actions/get-keyvault-secrets@main
         with:
-          keyvault: ${{ needs.setup.outputs.retrieve-secrets-keyvault }}
+          keyvault: ${{ needs.setup.outputs.retrive_secrets_keyvault }}
           secrets: "sa-bitwarden-web-vault-name,sp-bitwarden-web-vault-password,sp-bitwarden-web-vault-appid,sp-bitwarden-web-vault-tenant"
 
       - name: 'Download latest cloud asset using GitHub Run ID: ${{ inputs.build-web-run-id }}'
@@ -363,7 +363,7 @@ jobs:
         run: unzip ${{ env._ENVIRONMENT_ARTIFACT }}
 
       - name: Sync to Azure Storage Account using az storage blob sync
-        if: ${{ needs.setup.outputs.sync-utility == 'az-sync' }}
+        if: ${{ needs.setup.outputs.sync_utility == 'az-sync' }}
         working-directory: apps/web
         run: |
           az storage blob sync \
@@ -373,7 +373,7 @@ jobs:
             --delete-destination=${{ inputs.force-delete-destination }}
 
       - name: Sync to Azure Storage Account using azcopy
-        if: ${{ needs.setup.outputs.sync-utility == 'azcopy' }}
+        if: ${{ needs.setup.outputs.sync_utility == 'azcopy' }}
         working-directory: apps/web
         env:
           AZCOPY_AUTO_LOGIN_TYPE: SPN
@@ -397,7 +397,7 @@ jobs:
         uses: chrnorm/deployment-status@9a72af4586197112e0491ea843682b5dc280d806 # v2.0.3
         with:
           token: '${{ secrets.GITHUB_TOKEN }}'
-          environment-url: ${{ env._ENVIRONMENT_URL }}
+          environment_url: ${{ env._ENVIRONMENT_URL }}
           state: 'success'
           deployment-id: ${{ steps.deployment.outputs.deployment_id }}
 
@@ -406,7 +406,7 @@ jobs:
         uses: chrnorm/deployment-status@9a72af4586197112e0491ea843682b5dc280d806 # v2.0.3
         with:
           token: '${{ secrets.GITHUB_TOKEN }}'
-          environment-url: ${{ env._ENVIRONMENT_URL }}
+          environment_url: ${{ env._ENVIRONMENT_URL }}
           state: 'failure'
           deployment-id: ${{ steps.deployment.outputs.deployment_id }}
 
@@ -424,11 +424,11 @@ jobs:
         uses: bitwarden/gh-actions/report-deployment-status-to-slack@main
         with:
           project: Clients
-          environment: ${{ needs.setup.outputs.environment-name }}
+          environment: ${{ needs.setup.outputs.environment_name }}
           tag: ${{ inputs.branch-or-tag }}
           slack-channel: ${{ needs.notify-start.outputs.channel_id }}
           event: ${{ needs.azure-deploy.result }}
           url: https://github.com/bitwarden/clients/actions/runs/${{ github.run_id }}
-          commit-sha: ${{ needs.artifact-check.outputs.artifact-build-commit }}
+          commit-sha: ${{ needs.artifact-check.outputs.artifact_build_commit }}
           update-ts: ${{ needs.notify-start.outputs.ts }}
           AZURE_KV_CI_SERVICE_PRINCIPAL: ${{ secrets.AZURE_KV_CI_SERVICE_PRINCIPAL }}