[SM-468] Add eslint rule for forcing type to buttons (#4576)

* Add eslint rule for forcing type to buttons

* Fix eslint js errors

apps/desktop/src/app/layout/account-switcher.component.html

@@ -1,3 +1,5 @@
+<!-- Please remove this disable statement when editing this file! -->
+<!-- eslint-disable @angular-eslint/template/button-has-type -->
 <button
   class="account-switcher"
   (click)="toggle()"

apps/desktop/src/app/send/send.component.html

@@ -1,3 +1,5 @@
+<!-- Please remove this disable statement when editing this file! -->
+<!-- eslint-disable @angular-eslint/template/button-has-type -->
 <div id="sends" class="vault">
   <div class="left-nav">
     <div class="vault-filters">

apps/desktop/src/app/vault/vault-filter/filters/collection-filter.component.html

@@ -1,3 +1,5 @@
+<!-- Please remove this disable statement when editing this file! -->
+<!-- eslint-disable @angular-eslint/template/button-has-type -->
 <ng-container *ngIf="show">
   <div class="filter-heading">
     <h2>

apps/desktop/src/app/vault/vault-filter/filters/folder-filter.component.html

@@ -1,3 +1,5 @@
+<!-- Please remove this disable statement when editing this file! -->
+<!-- eslint-disable @angular-eslint/template/button-has-type -->
 <ng-container *ngIf="!hide">
   <div class="filter-heading">
     <h2>

apps/desktop/src/app/vault/vault-filter/filters/organization-filter.component.html

@@ -1,3 +1,5 @@
+<!-- Please remove this disable statement when editing this file! -->
+<!-- eslint-disable @angular-eslint/template/button-has-type -->
 <ng-container *ngIf="show">
   <ng-container [ngSwitch]="displayMode">
     <ng-container *ngSwitchCase="'personalOwnershipPolicy'">

apps/desktop/src/app/vault/vault-filter/filters/status-filter.component.html

@@ -1,3 +1,5 @@
+<!-- Please remove this disable statement when editing this file! -->
+<!-- eslint-disable @angular-eslint/template/button-has-type -->
 <ng-container *ngIf="show">
   <h2 class="sr-only">{{ "filters" | i18n }}</h2>
   <ul class="filter-options">

apps/desktop/src/app/vault/vault-filter/filters/type-filter.component.html

@@ -1,3 +1,5 @@
+<!-- Please remove this disable statement when editing this file! -->
+<!-- eslint-disable @angular-eslint/template/button-has-type -->
 <div class="filter-heading">
   <h2>
     <button

apps/desktop/src/app/vault/vault-items.component.html

@@ -1,3 +1,5 @@
+<!-- Please remove this disable statement when editing this file! -->
+<!-- eslint-disable @angular-eslint/template/button-has-type -->
 <div class="container loading-spinner" *ngIf="!loaded">
   <i class="bwi bwi-spinner bwi-spin bwi-3x" aria-hidden="true"></i>
 </div>

apps/desktop/src/app/vault/view.component.html

@@ -1,3 +1,5 @@
+<!-- Please remove this disable statement when editing this file! -->
+<!-- eslint-disable @angular-eslint/template/button-has-type -->
 <div class="content">
   <div class="inner-content" *ngIf="cipher">
     <div class="box">