From 4db6203e4edcc7f7de243bb785ba14dec238d3a0 Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 28 Oct 2025 21:22:26 +0000 Subject: [PATCH] refactor(dirt): remove dummy newApplications data Remove hardcoded dummy data now that newApplications are dynamically calculated from applicationData. Summary's newApplications field set to empty array as it's populated reactively. Related to PM-27284 --- .../domain/risk-insights-report.service.ts | 20 ++----------------- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/domain/risk-insights-report.service.ts b/bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/domain/risk-insights-report.service.ts index 470442a811b..09902bb8482 100644 --- a/bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/domain/risk-insights-report.service.ts +++ b/bitwarden_license/bit-common/src/dirt/reports/risk-insights/services/domain/risk-insights-report.service.ts @@ -56,23 +56,6 @@ export class RiskInsightsReportService { const atRiskMembers = reports.flatMap((x) => x.atRiskMemberDetails); const uniqueAtRiskMembers = getUniqueMembers(atRiskMembers); - // TODO: Replace with actual new applications detection logic (PM-26185) - const dummyNewApplications = [ - "github.com", - "google.com", - "stackoverflow.com", - "gitlab.com", - "bitbucket.org", - "npmjs.com", - "docker.com", - "aws.amazon.com", - "azure.microsoft.com", - "jenkins.io", - "terraform.io", - "kubernetes.io", - "atlassian.net", - ]; - return { totalMemberCount: uniqueMembers.length, totalAtRiskMemberCount: uniqueAtRiskMembers.length, @@ -82,7 +65,8 @@ export class RiskInsightsReportService { totalCriticalAtRiskMemberCount: 0, totalCriticalApplicationCount: 0, totalCriticalAtRiskApplicationCount: 0, - newApplications: dummyNewApplications, + // newApplications now derived from applicationData in orchestrator's newApplications$ observable + newApplications: [], }; }