[PM-16635] Remove InlineMenuFieldQualification feature flag references. (#13230)

* Remove InlineMenuFieldQualification feature flag references.

Removes all business logic related to InlineMenuFieldQualification Feature Flag, while leaving the flag in enum itself intact. No corresponding pull on server, where there exists no current references.

* Removes the feature flag from enum.

* Remove inlineMenuFieldQualificationFlagSet from InlineMenuFieldQualificationService.

* Removes deprecated isFieldForLoginFormFallback method.

apps/browser/src/autofill/services/inline-menu-field-qualification.service.spec.ts

@@ -17,7 +17,6 @@ describe("InlineMenuFieldQualificationService", () => {
       fields: [],
     });
     inlineMenuFieldQualificationService = new InlineMenuFieldQualificationService();
-    inlineMenuFieldQualificationService["inlineMenuFieldQualificationFlagSet"] = true;
   });
 
   describe("isFieldForLoginForm", () => {

apps/browser/src/autofill/services/inline-menu-field-qualification.service.ts

@@ -150,7 +150,6 @@ export class InlineMenuFieldQualificationService
     this.identityPostalCodeAutocompleteValue,
   ]);
   private totpFieldAutocompleteValue = "one-time-code";
-  private inlineMenuFieldQualificationFlagSet = false;
   private premiumEnabled = false;
 
   constructor() {
@@ -158,7 +157,6 @@ export class InlineMenuFieldQualificationService
       sendExtensionMessage("getInlineMenuFieldQualificationFeatureFlag"),
       sendExtensionMessage("getUserPremiumStatus"),
     ]).then(([fieldQualificationFlag, premiumStatus]) => {
-      this.inlineMenuFieldQualificationFlagSet = !!fieldQualificationFlag?.result;
       this.premiumEnabled = !!premiumStatus?.result;
     });
   }
@@ -170,10 +168,6 @@ export class InlineMenuFieldQualificationService
    * @param pageDetails - The details of the page that the field is on.
    */
   isFieldForLoginForm(field: AutofillField, pageDetails: AutofillPageDetails): boolean {
-    if (!this.inlineMenuFieldQualificationFlagSet) {
-      return this.isFieldForLoginFormFallback(field);
-    }
-
     /**
      * Totp inline menu is available only for premium users.
      */
@@ -1223,18 +1217,4 @@ export class InlineMenuFieldQualificationService
 
     return false;
   }
-
-  /**
-   * This method represents the previous rudimentary approach to qualifying fields for login forms.
-   *
-   * @param field - The field to validate
-   * @deprecated - This method will only be used when the fallback flag is set to true.
-   */
-  private isFieldForLoginFormFallback(field: AutofillField): boolean {
-    if (field.type === "password") {
-      return true;
-    }
-
-    return this.isUsernameField(field);
-  }
 }

apps/browser/src/background/runtime.background.ts

@@ -80,7 +80,6 @@ export default class RuntimeBackground {
         BiometricsCommands.GetBiometricsStatusForUser,
         BiometricsCommands.CanEnableBiometricUnlock,
         "getUseTreeWalkerApiForPageDetailsCollectionFeatureFlag",
-        "getInlineMenuFieldQualificationFeatureFlag",
         "getUserPremiumStatus",
       ];
 
@@ -210,9 +209,6 @@ export default class RuntimeBackground {
           FeatureFlag.UseTreeWalkerApiForPageDetailsCollection,
         );
       }
-      case "getInlineMenuFieldQualificationFeatureFlag": {
-        return await this.configService.getFeatureFlag(FeatureFlag.InlineMenuFieldQualification);
-      }
       case "getUserPremiumStatus": {
         const activeUserId = await firstValueFrom(
           this.accountService.activeAccount$.pipe(map((a) => a?.id)),

libs/common/src/enums/feature-flag.enum.ts

@@ -22,7 +22,6 @@ export enum FeatureFlag {
   EnableNewCardCombinedExpiryAutofill = "enable-new-card-combined-expiry-autofill",
   GenerateIdentityFillScriptRefactor = "generate-identity-fill-script-refactor",
   IdpAutoSubmitLogin = "idp-auto-submit-login",
-  InlineMenuFieldQualification = "inline-menu-field-qualification",
   InlineMenuPositioningImprovements = "inline-menu-positioning-improvements",
   NotificationBarAddLoginImprovements = "notification-bar-add-login-improvements",
   NotificationRefresh = "notification-refresh",
@@ -84,7 +83,6 @@ export const DefaultFeatureFlagValue = {
   [FeatureFlag.EnableNewCardCombinedExpiryAutofill]: FALSE,
   [FeatureFlag.GenerateIdentityFillScriptRefactor]: FALSE,
   [FeatureFlag.IdpAutoSubmitLogin]: FALSE,
-  [FeatureFlag.InlineMenuFieldQualification]: FALSE,
   [FeatureFlag.InlineMenuPositioningImprovements]: FALSE,
   [FeatureFlag.NotificationBarAddLoginImprovements]: FALSE,
   [FeatureFlag.NotificationRefresh]: FALSE,