bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-19 01:33:33 +00:00
Code Issues Releases Wiki Activity

[PM-25203] Resolve circular dependencies through LooseComponentsModule (#16157)

Browse Source 
* Update modules to not import loose-components

Instead they should import their dependencies directly.
Only OssModule imports loose-components.module.ts.

* Remove unused imports and exports
This commit is contained in:
Thomas Rittson
2025-08-27 22:10:32 +10:00
committed by GitHub
parent c72fdebfd9
commit 4f09ae52ab
16 changed files with 38 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
bitwarden_license/bit-web/src/app/admin-console/organizations/manage/device-approvals/device-approvals.component.ts
View File

@@ -21,7 +21,7 @@ import { PlatformUtilsService } from "@bitwarden/common/platform/abstractions/pl
import { ValidationService } from "@bitwarden/common/platform/abstractions/validation.service";
import { TableDataSource, NoItemsModule, ToastService } from "@bitwarden/components";
import { KeyService } from "@bitwarden/key-management";
import { LooseComponentsModule } from "@bitwarden/web-vault/app/shared";
import { HeaderModule } from "@bitwarden/web-vault/app/layouts/header/header.module";
import { SharedModule } from "@bitwarden/web-vault/app/shared/shared.module";
@Component({
@@ -43,7 +43,7 @@ import { SharedModule } from "@bitwarden/web-vault/app/shared/shared.module";
],
}),
] satisfies SafeProvider[],
imports: [SharedModule, NoItemsModule, LooseComponentsModule],
imports: [SharedModule, NoItemsModule, HeaderModule],
})
export class DeviceApprovalsComponent implements OnInit, OnDestroy {
tableDataSource = new TableDataSource<PendingAuthRequestWithFingerprintView>();

4
bitwarden_license/bit-web/src/app/admin-console/organizations/organizations.module.ts
View File

@@ -1,6 +1,6 @@
import { NgModule } from "@angular/core";
import { LooseComponentsModule } from "@bitwarden/web-vault/app/shared";
import { HeaderModule } from "@bitwarden/web-vault/app/layouts/header/header.module";
import { SharedModule } from "@bitwarden/web-vault/app/shared/shared.module";
import { SsoComponent } from "../../auth/sso/sso.component";
@@ -11,7 +11,7 @@ import { ScimComponent } from "./manage/scim.component";
import { OrganizationsRoutingModule } from "./organizations-routing.module";
@NgModule({
imports: [SharedModule, OrganizationsRoutingModule, LooseComponentsModule],
imports: [SharedModule, OrganizationsRoutingModule, HeaderModule],
declarations: [
SsoComponent,
ScimComponent,