From 520628c99ba7df268160aa09a0c5ac27e6fb93bb Mon Sep 17 00:00:00 2001 From: gbubemismith Date: Sat, 9 Sep 2023 23:22:18 -0400 Subject: [PATCH] updated test cases and services using the config service --- .../src/vault/services/fido2/fido2-client.service.spec.ts | 6 +++--- .../common/src/vault/services/fido2/fido2-client.service.ts | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libs/common/src/vault/services/fido2/fido2-client.service.spec.ts b/libs/common/src/vault/services/fido2/fido2-client.service.spec.ts index a19afa6aaa1..2b820fea865 100644 --- a/libs/common/src/vault/services/fido2/fido2-client.service.spec.ts +++ b/libs/common/src/vault/services/fido2/fido2-client.service.spec.ts @@ -30,7 +30,7 @@ describe("FidoAuthenticatorService", () => { authenticator = mock(); configService = mock(); client = new Fido2ClientService(authenticator, configService); - configService.getFeatureFlagBool.mockResolvedValue(true); + configService.getFeatureFlag.mockResolvedValue(true); }); describe("createCredential", () => { @@ -197,7 +197,7 @@ describe("FidoAuthenticatorService", () => { it("should throw FallbackRequestedError if feature flag is not enabled", async () => { const params = createParams(); - configService.getFeatureFlagBool.mockResolvedValue(false); + configService.getFeatureFlag.mockResolvedValue(false); const result = async () => await client.createCredential(params); @@ -335,7 +335,7 @@ describe("FidoAuthenticatorService", () => { it("should throw FallbackRequestedError if feature flag is not enabled", async () => { const params = createParams(); - configService.getFeatureFlagBool.mockResolvedValue(false); + configService.getFeatureFlag.mockResolvedValue(false); const result = async () => await client.assertCredential(params); diff --git a/libs/common/src/vault/services/fido2/fido2-client.service.ts b/libs/common/src/vault/services/fido2/fido2-client.service.ts index 55a62949465..b9432dae14c 100644 --- a/libs/common/src/vault/services/fido2/fido2-client.service.ts +++ b/libs/common/src/vault/services/fido2/fido2-client.service.ts @@ -35,7 +35,7 @@ export class Fido2ClientService implements Fido2ClientServiceAbstraction { ) {} async isFido2FeatureEnabled(): Promise { - return await this.configService.getFeatureFlagBool(FeatureFlag.Fido2VaultCredentials); + return await this.configService.getFeatureFlag(FeatureFlag.Fido2VaultCredentials); } async createCredential(