From da9dca6dd601fdfe3550ff128cbbdaa8def0c67b Mon Sep 17 00:00:00 2001 From: "Patrick H. Lauke" Date: Tue, 16 Aug 2022 19:51:45 +0100 Subject: [PATCH 1/9] Don't suppress outline for input[type="file"] controls (#3210) Closes https://github.com/bitwarden/clients/issues/3209 --- apps/browser/src/popup/scss/box.scss | 2 +- apps/desktop/src/scss/box.scss | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/browser/src/popup/scss/box.scss b/apps/browser/src/popup/scss/box.scss index 9629ddae6f8..7139f4514dc 100644 --- a/apps/browser/src/popup/scss/box.scss +++ b/apps/browser/src/popup/scss/box.scss @@ -441,7 +441,7 @@ } } - &:focus { + &:not([type="file"]):focus { outline: none; } } diff --git a/apps/desktop/src/scss/box.scss b/apps/desktop/src/scss/box.scss index aa11b408a42..b3bd4004e24 100644 --- a/apps/desktop/src/scss/box.scss +++ b/apps/desktop/src/scss/box.scss @@ -343,7 +343,7 @@ } } - &:focus { + &:not([type="file"]):focus { outline: none; } } From b1a47b85b59f05f0f5298d55372fe86fdd56950f Mon Sep 17 00:00:00 2001 From: "Patrick H. Lauke" Date: Tue, 16 Aug 2022 20:05:31 +0100 Subject: [PATCH 2/9] [PS-1303] Desktop/browser: tweak `.box-header-expandable` styles (#3308) * Add extra margin for desktop settings expanded header buttons * Only change box-header-expandable background on `:focus-visible` not `:focus` Avoids having the background colour "stick" when clicking with the mouse until you click somewhere else --- apps/browser/src/popup/scss/box.scss | 2 +- apps/desktop/src/scss/box.scss | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/apps/browser/src/popup/scss/box.scss b/apps/browser/src/popup/scss/box.scss index 7139f4514dc..6e0b6f9356a 100644 --- a/apps/browser/src/popup/scss/box.scss +++ b/apps/browser/src/popup/scss/box.scss @@ -33,7 +33,7 @@ } &:hover, - &:focus, + &:focus-visible, &.active { @include themify($themes) { background-color: themed("boxBackgroundHoverColor"); diff --git a/apps/desktop/src/scss/box.scss b/apps/desktop/src/scss/box.scss index b3bd4004e24..64cbf370abf 100644 --- a/apps/desktop/src/scss/box.scss +++ b/apps/desktop/src/scss/box.scss @@ -48,7 +48,7 @@ } &:hover, - &:focus, + &:focus-visible, &.active { @include themify($themes) { background-color: themed("boxBackgroundHoverColor"); @@ -77,6 +77,10 @@ &.box-content-padded { padding: 10px 15px; + + .box-header-expandable[aria-expanded="true"] { + margin-bottom: 1rem; + } } &.condensed .box-content-row, From 1137f83535aeed429a1785b789b39ede588c2403 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue, 16 Aug 2022 12:47:42 -0700 Subject: [PATCH 3/9] Bumped desktop version to 2022.8.2 (#3319) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- apps/desktop/package.json | 2 +- apps/desktop/src/package-lock.json | 4 ++-- apps/desktop/src/package.json | 2 +- package-lock.json | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/apps/desktop/package.json b/apps/desktop/package.json index c0b306d8373..a283b68e519 100644 --- a/apps/desktop/package.json +++ b/apps/desktop/package.json @@ -1,7 +1,7 @@ { "name": "@bitwarden/desktop", "description": "A secure and free password manager for all of your devices.", - "version": "2022.8.1", + "version": "2022.8.2", "keywords": [ "bitwarden", "password", diff --git a/apps/desktop/src/package-lock.json b/apps/desktop/src/package-lock.json index a491ab12ecd..cc99cdb53e2 100644 --- a/apps/desktop/src/package-lock.json +++ b/apps/desktop/src/package-lock.json @@ -1,12 +1,12 @@ { "name": "@bitwarden/desktop", - "version": "2022.8.1", + "version": "2022.8.2", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@bitwarden/desktop", - "version": "2022.8.1", + "version": "2022.8.2", "license": "GPL-3.0", "dependencies": { "@bitwarden/desktop-native": "file:../desktop_native" diff --git a/apps/desktop/src/package.json b/apps/desktop/src/package.json index 045762aa2d1..aa912f42231 100644 --- a/apps/desktop/src/package.json +++ b/apps/desktop/src/package.json @@ -2,7 +2,7 @@ "name": "@bitwarden/desktop", "productName": "Bitwarden", "description": "A secure and free password manager for all of your devices.", - "version": "2022.8.1", + "version": "2022.8.2", "author": "Bitwarden Inc. (https://bitwarden.com)", "homepage": "https://bitwarden.com", "license": "GPL-3.0", diff --git a/package-lock.json b/package-lock.json index 67195454887..60dfc237cb8 100644 --- a/package-lock.json +++ b/package-lock.json @@ -221,7 +221,7 @@ }, "apps/desktop": { "name": "@bitwarden/desktop", - "version": "2022.8.1", + "version": "2022.8.2", "hasInstallScript": true, "license": "GPL-3.0" }, From e7da2f0c22bfb3c10a4b439eef103b9ffd307686 Mon Sep 17 00:00:00 2001 From: Tomi Belan Date: Tue, 16 Aug 2022 23:27:05 +0200 Subject: [PATCH 4/9] Allow bw sync without unlocking (#2916) --- apps/cli/src/program.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/cli/src/program.ts b/apps/cli/src/program.ts index 80eddf0c5e6..c4cdd2bf50f 100644 --- a/apps/cli/src/program.ts +++ b/apps/cli/src/program.ts @@ -281,7 +281,7 @@ export class Program extends BaseProgram { writeLn("", true); }) .action(async (cmd) => { - await this.exitIfLocked(); + await this.exitIfNotAuthed(); const command = new SyncCommand(this.main.syncService); const response = await command.run(cmd); this.processResponse(response); From babfa30c68bca243fc9bac4e33c8af8005dbad2d Mon Sep 17 00:00:00 2001 From: "Patrick H. Lauke" Date: Wed, 17 Aug 2022 09:42:26 +0100 Subject: [PATCH 5/9] [PS-1222] Remove `appBlurClick` throughout the popup and web code (#3208) * Remove appBlurClick throughout the popup code `appBlurClick` leads to focus being lost/reset for assistive technology users. It should not be necessary in any case - if focus does need to move after an action, explicitly set it somewhere programmatically using `focus()` rather than relying on browser heuristics * Remove now redundant blur-click directive --- .../src/popup/vault/vault-select.component.html | 9 +-------- .../app/components/password-reprompt.component.html | 2 +- libs/angular/src/directives/blur-click.directive.ts | 12 ------------ libs/angular/src/jslib.module.ts | 3 --- 4 files changed, 2 insertions(+), 24 deletions(-) delete mode 100644 libs/angular/src/directives/blur-click.directive.ts diff --git a/apps/browser/src/popup/vault/vault-select.component.html b/apps/browser/src/popup/vault/vault-select.component.html index 2101b7c019f..ec4d4ff9e3e 100644 --- a/apps/browser/src/popup/vault/vault-select.component.html +++ b/apps/browser/src/popup/vault/vault-select.component.html @@ -26,26 +26,19 @@ > - - +
diff --git a/apps/desktop/src/app/accounts/premium.component.html b/apps/desktop/src/app/accounts/premium.component.html index 01c181daa81..f47f377cff2 100644 --- a/apps/desktop/src/app/accounts/premium.component.html +++ b/apps/desktop/src/app/accounts/premium.component.html @@ -3,9 +3,9 @@