From 53a290849afa555f8d24512c9cab5fd9064737cc Mon Sep 17 00:00:00 2001 From: Shane Melton Date: Wed, 10 Jul 2024 11:41:37 -0700 Subject: [PATCH] [PM-8524] Add note regarding existing login view references --- .../login-details-section/login-details-section.component.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libs/vault/src/cipher-form/components/login-details-section/login-details-section.component.ts b/libs/vault/src/cipher-form/components/login-details-section/login-details-section.component.ts index bd6e2ee7b74..5aef61a5ddf 100644 --- a/libs/vault/src/cipher-form/components/login-details-section/login-details-section.component.ts +++ b/libs/vault/src/cipher-form/components/login-details-section/login-details-section.component.ts @@ -123,6 +123,8 @@ export class LoginDetailsSectionComponent implements OnInit { } private initFromExistingCipher(existingLogin: LoginView) { + // Note: this.loginView will still contain references to the existing login's Uri and Fido2Credential arrays. + // We may need to deep clone these in the future. Object.assign(this.loginView, existingLogin); this.loginDetailsForm.patchValue({ username: this.loginView.username,