From 547c7b8b70c968af43eabebf665e29340c5c7336 Mon Sep 17 00:00:00 2001 From: Kyle Spearrin Date: Thu, 29 Jun 2017 12:35:10 -0400 Subject: [PATCH] nfc flag for yubi and duo mobile page --- gulpfile.js | 1 + .../views/accountsLoginTwoFactor.html | 2 +- .../settings/settingsTwoStepYubiController.js | 12 +--- .../settings/views/settingsTwoStepYubi.html | 36 ++++------ src/duo-mobile.html | 68 +++++++++++++++++++ 5 files changed, 84 insertions(+), 35 deletions(-) create mode 100644 src/duo-mobile.html diff --git a/gulpfile.js b/gulpfile.js index 49d0b9beb59..21e9503d9ab 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -442,6 +442,7 @@ gulp.task('serve', function () { connect.server({ port: 4001, root: ['src'], + //https: true, middleware: function (connect, opt) { return [function (req, res, next) { if (req.originalUrl.indexOf('app-id.json') > -1) { diff --git a/src/app/accounts/views/accountsLoginTwoFactor.html b/src/app/accounts/views/accountsLoginTwoFactor.html index 87f5a9c611d..23108e59bdc 100644 --- a/src/app/accounts/views/accountsLoginTwoFactor.html +++ b/src/app/accounts/views/accountsLoginTwoFactor.html @@ -145,7 +145,7 @@

- This account has two-factor login enabled, however, none of the configured two-factor providers are supported by this + This account has two-step login enabled, however, none of the configured two-step providers are supported by this web browser.

Please use a supported web browser (such as Chrome) and/or add additional providers that are better supported diff --git a/src/app/settings/settingsTwoStepYubiController.js b/src/app/settings/settingsTwoStepYubiController.js index c21a12011d0..05e2c274da8 100644 --- a/src/app/settings/settingsTwoStepYubiController.js +++ b/src/app/settings/settingsTwoStepYubiController.js @@ -33,8 +33,7 @@ key1: model.key1.key, key2: model.key2.key, key3: model.key3.key, - key4: model.key4.key, - key5: model.key5.key, + nfc: model.nfc, masterPasswordHash: _masterPasswordHash }, function (response) { $analytics.eventTrack('Saved Two-step YubiKey'); @@ -79,14 +78,7 @@ key: response.Key3, existingKey: padRight(response.Key3, '*', 44) }, - key4: { - key: response.Key4, - existingKey: padRight(response.Key4, '*', 44) - }, - key5: { - key: response.Key5, - existingKey: padRight(response.Key5, '*', 44) - } + nfc: response.Nfc === true || !response.Enabled }; } diff --git a/src/app/settings/views/settingsTwoStepYubi.html b/src/app/settings/views/settingsTwoStepYubi.html index 4849bbf5322..15347dc89cf 100644 --- a/src/app/settings/views/settingsTwoStepYubi.html +++ b/src/app/settings/views/settingsTwoStepYubi.html @@ -69,7 +69,7 @@
- + [remove] @@ -80,7 +80,7 @@ ng-show="!updateModel.key1.existingKey" />
- + [remove] @@ -91,7 +91,7 @@ ng-show="!updateModel.key2.existingKey" />
- + [remove] @@ -101,28 +101,16 @@
-
- - - [remove] - -
- {{updateModel.key4.existingKey}} -
- -
-
- - - [remove] - -
- {{updateModel.key5.existingKey}} -
- + NFC Support +
+
+

+ If one of your YubiKeys supports NFC (such as a YubiKey NEO), you will be prompted on mobile devices whenever NFC + availability is detected. +