ENG-71 - Updated release workflows with cleanup recommended by Vince (#3224)

* Updated release jobs to include fixes that Vince recommended from the mobile repo

* Updated the workflows with the fixes
that Vince recommended from mobile.

* Fix linter errors

Co-authored-by: Todd Martin <>
Co-authored-by: Michal Checinski <michal.checinski@outlook.com>

.github/workflows/release-web.yml

@@ -232,18 +232,11 @@ jobs:
         id: deployment
         with:
           token: '${{ secrets.GITHUB_TOKEN }}'
+          initial-status: 'in_progress'
           environment-url: http://vault.bitwarden.com
           environment: 'Web Vault - Production'
           description: 'Deployment ${{ needs.setup.outputs.release_version }} from branch ${{ github.ref_name }}'
           task: release
-      
-      - name: Update deployment status to In Progress
-        uses: chrnorm/deployment-status@07b3930847f65e71c9c6802ff5a402f6dfb46b86
-        with:
-          token: '${{ secrets.GITHUB_TOKEN }}'
-          environment-url: http://vault.bitwarden.com
-          state: 'in_progress'
-          deployment-id: ${{ steps.deployment.outputs.deployment_id }}
 
       - name: Download latest build artifacts
         if: ${{ github.event.inputs.release_type != 'Dry Run' }}
@@ -287,7 +280,7 @@ jobs:
           draft: true
 
       - name: Update deployment status to Success
-        if: success()
+        if: ${{ success() }}
         uses: chrnorm/deployment-status@07b3930847f65e71c9c6802ff5a402f6dfb46b86
         with:
           token: '${{ secrets.GITHUB_TOKEN }}'
@@ -296,7 +289,7 @@ jobs:
           deployment-id: ${{ steps.deployment.outputs.deployment_id }}
 
       - name: Update deployment status to Failure
-        if: failure()
+        if: ${{ failure() }}
         uses: chrnorm/deployment-status@07b3930847f65e71c9c6802ff5a402f6dfb46b86
         with:
           token: '${{ secrets.GITHUB_TOKEN }}'