bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-18 01:03:35 +00:00
Code Issues Releases Wiki Activity

[PM-16132][16249] Custom hidden field missing color and character count toggle (#13402)

Browse Source 
* Add colored characters to custom hidden field

* Add character count toggle to hidden field

* Check correct variable for revealed hidden field

* Merge branch 'main' into vault/pm-16132/custom-hidden-field-missing-color-and-character-count-toggle

* Toggle character count on per field basis

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Co-authored-by: bnagawiecki <107435978+bnagawiecki@users.noreply.github.com>
Co-authored-by: Leslie Tilton <23057410+Banrion@users.noreply.github.com>
This commit is contained in:
Daniel James Smith
2025-05-07 16:53:57 +02:00
committed by GitHub
parent d5a7e563c1
commit 574891d617
2 changed files with 36 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
libs/vault/src/cipher-view/custom-fields/custom-fields-v2.component.ts
View File

@@ -21,6 +21,7 @@ import {
SectionHeaderComponent,
TypographyModule,
CheckboxModule,
ColorPasswordModule,
} from "@bitwarden/components";
import { VaultAutosizeReadOnlyTextArea } from "../../directives/readonly-textarea.directive";
@@ -40,6 +41,7 @@ import { VaultAutosizeReadOnlyTextArea } from "../../directives/readonly-textare
SectionHeaderComponent,
TypographyModule,
CheckboxModule,
ColorPasswordModule,
VaultAutosizeReadOnlyTextArea,
],
})
@@ -51,6 +53,11 @@ export class CustomFieldV2Component implements OnInit {
/** Indexes of hidden fields that are revealed */
revealedHiddenFields: number[] = [];
/**
* Indicates whether the hidden field's character count should be shown
*/
showHiddenValueCountFields: number[] = [];
constructor(
private i18nService: I18nService,
private eventCollectionService: EventCollectionService,
@@ -69,6 +76,15 @@ export class CustomFieldV2Component implements OnInit {
return this.cipher.viewPassword;
}
toggleCharacterCount(index: number) {
const fieldIndex = this.showHiddenValueCountFields.indexOf(index);
if (fieldIndex > -1) {
this.showHiddenValueCountFields.splice(fieldIndex, 1);
} else {
this.showHiddenValueCountFields.push(index);
}
}
async toggleHiddenField(hiddenFieldVisible: boolean, index: number) {
if (hiddenFieldVisible) {
this.revealedHiddenFields.push(index);