bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-11 22:03:36 +00:00
Code Issues Releases Wiki Activity

PM-25931 fixing bugs found by QA (#16472)

Browse Source
This commit is contained in:
Vijay Oommen
2025-09-18 11:03:00 -05:00
committed by GitHub
parent f04b24851c
commit 57705791db
5 changed files with 24 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
apps/web/src/locales/en/messages.json
View File

@@ -9845,6 +9845,9 @@
"bearerToken": { "bearerToken": {
"message": "Bearer Token" "message": "Bearer Token"
}, },
"repositoryNameHint": {
"message": "Name of the repository to ingest into"
},
"index": { "index": {
"message": "Index" "message": "Index"
}, },

8
bitwarden_license/bit-common/src/dirt/organization-integrations/services/organization-integration-configuration-api.service.spec.ts
View File

@@ -49,7 +49,7 @@ describe("OrganizationIntegrationConfigurationApiService", () => {
expect(result).toEqual(mockConfigurationResponses); expect(result).toEqual(mockConfigurationResponses);
expect(apiService.send).toHaveBeenCalledWith( expect(apiService.send).toHaveBeenCalledWith(
"GET", "GET",
`organizations/${orgId}/integrations/${integrationId}/configurations`, `/organizations/${orgId}/integrations/${integrationId}/configurations`,
null, null,
true, true,
true, true,
@@ -77,7 +77,7 @@ describe("OrganizationIntegrationConfigurationApiService", () => {
expect(result.template).toEqual(mockConfigurationResponse.template); expect(result.template).toEqual(mockConfigurationResponse.template);
expect(apiService.send).toHaveBeenCalledWith( expect(apiService.send).toHaveBeenCalledWith(
"POST", "POST",
`organizations/${orgId}/integrations/${integrationId}/configurations`, `/organizations/${orgId}/integrations/${integrationId}/configurations`,
request, request,
true, true,
true, true,
@@ -107,7 +107,7 @@ describe("OrganizationIntegrationConfigurationApiService", () => {
expect(result.template).toEqual(mockConfigurationResponse.template); expect(result.template).toEqual(mockConfigurationResponse.template);
expect(apiService.send).toHaveBeenCalledWith( expect(apiService.send).toHaveBeenCalledWith(
"PUT", "PUT",
`organizations/${orgId}/integrations/${integrationId}/configurations/${configurationId}`, `/organizations/${orgId}/integrations/${integrationId}/configurations/${configurationId}`,
request, request,
true, true,
true, true,
@@ -123,7 +123,7 @@ describe("OrganizationIntegrationConfigurationApiService", () => {
expect(apiService.send).toHaveBeenCalledWith( expect(apiService.send).toHaveBeenCalledWith(
"DELETE", "DELETE",
`organizations/${orgId}/integrations/${integrationId}/configurations/${configurationId}`, `/organizations/${orgId}/integrations/${integrationId}/configurations/${configurationId}`,
null, null,
true, true,
false, false,

8
bitwarden_license/bit-common/src/dirt/organization-integrations/services/organization-integration-configuration-api.service.ts
View File

@@ -17,7 +17,7 @@ export class OrganizationIntegrationConfigurationApiService {
): Promise<OrganizationIntegrationConfigurationResponse[]> { ): Promise<OrganizationIntegrationConfigurationResponse[]> {
const responses = await this.apiService.send( const responses = await this.apiService.send(
"GET", "GET",
`organizations/${orgId}/integrations/${integrationId}/configurations`, `/organizations/${orgId}/integrations/${integrationId}/configurations`,
null, null,
true, true,
true, true,
@@ -32,7 +32,7 @@ export class OrganizationIntegrationConfigurationApiService {
): Promise<OrganizationIntegrationConfigurationResponse> { ): Promise<OrganizationIntegrationConfigurationResponse> {
const response = await this.apiService.send( const response = await this.apiService.send(
"POST", "POST",
`organizations/${orgId}/integrations/${integrationId}/configurations`, `/organizations/${orgId}/integrations/${integrationId}/configurations`,
request, request,
true, true,
true, true,
@@ -48,7 +48,7 @@ export class OrganizationIntegrationConfigurationApiService {
): Promise<OrganizationIntegrationConfigurationResponse> { ): Promise<OrganizationIntegrationConfigurationResponse> {
const response = await this.apiService.send( const response = await this.apiService.send(
"PUT", "PUT",
`organizations/${orgId}/integrations/${integrationId}/configurations/${configurationId}`, `/organizations/${orgId}/integrations/${integrationId}/configurations/${configurationId}`,
request, request,
true, true,
true, true,
@@ -63,7 +63,7 @@ export class OrganizationIntegrationConfigurationApiService {
): Promise<any> { ): Promise<any> {
await this.apiService.send( await this.apiService.send(
"DELETE", "DELETE",
`organizations/${orgId}/integrations/${integrationId}/configurations/${configurationId}`, `/organizations/${orgId}/integrations/${integrationId}/configurations/${configurationId}`,
null, null,
true, true,
false, false,

2
bitwarden_license/bit-web/src/app/dirt/organization-integrations/integration-card/integration-card.component.html
View File

@@ -30,7 +30,7 @@
</span> </span>
} }
</h3> </h3>
<p class="tw-mb-0">{{ description }}</p> <p class="tw-mb-0 tw-font-semibold">{{ description }}</p>
@if (canSetupConnection) { @if (canSetupConnection) {
<button type="button" class="tw-mt-3" bitButton (click)="setupConnection()"> <button type="button" class="tw-mt-3" bitButton (click)="setupConnection()">

15
bitwarden_license/bit-web/src/app/dirt/organization-integrations/integration-dialog/connect-dialog/connect-dialog-hec.component.html
View File

@@ -13,15 +13,24 @@
<ng-container> <ng-container>
<bit-form-field> <bit-form-field>
<bit-label>{{ "url" | i18n }}</bit-label> <bit-label>{{ "url" | i18n }}</bit-label>
<input bitInput formControlName="url" /> <input
bitInput
type="text"
formControlName="url"
placeholder="https://<customer-id>.crowdstrike.com"
/>
</bit-form-field> </bit-form-field>
<bit-form-field> <bit-form-field>
<bit-label>{{ "bearerToken" | i18n }}</bit-label> <bit-label>{{ "bearerToken" | i18n }}</bit-label>
<input bitInput formControlName="bearerToken" /> <input bitInput type="text" formControlName="bearerToken" />
<bit-hint>{{ "apiKey" | i18n }}</bit-hint>
</bit-form-field> </bit-form-field>
<bit-form-field> <bit-form-field>
<bit-label>{{ "index" | i18n }}</bit-label> <bit-label>{{ "index" | i18n }}</bit-label>
<input bitInput formControlName="index" /> <input bitInput type="text" formControlName="index" />
<bit-hint>{{ "repositoryNameHint" | i18n }}</bit-hint>
</bit-form-field> </bit-form-field>
</ng-container> </ng-container>
} }