From 57dce095b2a4f3835631a0798fc16700e3fe6cb6 Mon Sep 17 00:00:00 2001 From: Vicki League Date: Wed, 25 Jun 2025 17:04:42 -0400 Subject: [PATCH] tabs module improvements part 2 --- libs/components/src/tabs/shared/tab-list-item.directive.ts | 2 +- libs/components/src/tabs/tab-group/tab-group.component.ts | 2 +- libs/components/src/tabs/tab-nav-bar/tab-link.component.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libs/components/src/tabs/shared/tab-list-item.directive.ts b/libs/components/src/tabs/shared/tab-list-item.directive.ts index 815d09038f3..b9952f6671e 100644 --- a/libs/components/src/tabs/shared/tab-list-item.directive.ts +++ b/libs/components/src/tabs/shared/tab-list-item.directive.ts @@ -11,7 +11,7 @@ import { Directive, ElementRef, HostBinding, Input, input } from "@angular/core" selector: "[bitTabListItem]", }) export class TabListItemDirective implements FocusableOption { - readonly active = input(undefined); + readonly active = input(); // TODO: Skipped for signal migration because: // This input overrides a field from a superclass, while the superclass field // is not migrated. diff --git a/libs/components/src/tabs/tab-group/tab-group.component.ts b/libs/components/src/tabs/tab-group/tab-group.component.ts index 9b99d50d7c3..2bd81375d39 100644 --- a/libs/components/src/tabs/tab-group/tab-group.component.ts +++ b/libs/components/src/tabs/tab-group/tab-group.component.ts @@ -63,7 +63,7 @@ export class TabGroupComponent @ViewChildren(TabListItemDirective) tabLabels: QueryList; /** The index of the active tab. */ - // TODO: Skipped for migration because: + // TODO: Skipped for signal migration because: // Accessor inputs cannot be migrated as they are too complex. @Input() get selectedIndex(): number | null { diff --git a/libs/components/src/tabs/tab-nav-bar/tab-link.component.ts b/libs/components/src/tabs/tab-nav-bar/tab-link.component.ts index 55963cba492..f1b279c4371 100644 --- a/libs/components/src/tabs/tab-nav-bar/tab-link.component.ts +++ b/libs/components/src/tabs/tab-nav-bar/tab-link.component.ts @@ -35,7 +35,7 @@ export class TabLinkComponent implements FocusableOption, AfterViewInit, OnDestr fragment: "ignored", }; - readonly route = input(undefined); + readonly route = input(); // TODO: Skipped for signal migration because: // This input overrides a field from a superclass, while the superclass field // is not migrated.